linux-kernel - Re: [PATCH] pinctrl: pinconf-generic: Print unsigned value if a format is registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZh0mDkob62k=_v+eMqn-mKNpeetS3h38wpNHWyA+Eijw@mail.gmail.com>
Date: Thu, 6 Feb 2025 10:15:01 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Claudiu <claudiu.beznea@...on.dev>
Cc: peng.fan@....com, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH] pinctrl: pinconf-generic: Print unsigned value if a
 format is registered

On Wed, Feb 5, 2025 at 11:11 AM Claudiu <claudiu.beznea@...on.dev> wrote:

> From: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
>
> Commit 3ba11e684d16 ("pinctrl: pinconf-generic: print hex value")
> unconditionally switched to printing hex values in
> pinconf_generic_dump_one(). However, if a dump format is registered for the
> dumped pin, the hex value is printed as well. This hex value does not
> necessarily correspond 1:1 with the hardware register value (as noted by
> commit 3ba11e684d16 ("pinctrl: pinconf-generic: print hex value")). As a
> result, user-facing output may include information like:
> output drive strength (0x100 uA).
>
> To address this, check if a dump format is registered for the dumped
> property, and print the unsigned value instead when applicable.
>
> Fixes: 3ba11e684d16 ("pinctrl: pinconf-generic: print hex value")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>

Patch applied!

Yours,
Linus Walleij