linux-kernel - Re: [PATCH v2 2/2] KVM: SVM: Limit AVIC physical max index based on configured max_vcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7bzch3zo3r77grfk4lywxdqkjlzfxaqrapdwcl4xgajnhh7nl6@jlr3eetu7lj7>
Date: Thu, 6 Feb 2025 14:42:49 +0530
From: Naveen N Rao <naveen@...nel.org>
To: Vasant Hegde <vasant.hegde@....com>
Cc: kvm@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Sean Christopherson <seanjc@...gle.com>, Paolo Bonzini <pbonzini@...hat.com>, 
	Suravee Suthikulpanit <suravee.suthikulpanit@....com>
Subject: Re: [PATCH v2 2/2] KVM: SVM: Limit AVIC physical max index based on
 configured max_vcpu_ids

Hi Vasant,

On Wed, Feb 05, 2025 at 12:18:29PM +0530, Vasant Hegde wrote:
> Hi Naveen,
> 
> 
> On 2/3/2025 12:07 PM, Naveen N Rao (AMD) wrote:

<snip>

> >  void avic_vm_destroy(struct kvm *kvm)
> >  {
> >  	unsigned long flags;
> > @@ -185,7 +202,8 @@ void avic_vm_destroy(struct kvm *kvm)
> >  	if (kvm_svm->avic_logical_id_table_page)
> >  		__free_page(kvm_svm->avic_logical_id_table_page);
> >  	if (kvm_svm->avic_physical_id_table_page)
> > -		__free_page(kvm_svm->avic_physical_id_table_page);
> > +		__free_pages(kvm_svm->avic_physical_id_table_page,
> > +			     avic_get_physical_id_table_order(kvm));
> 
> Move this hunk to previous patch (1/2) ?
> 
> Rest looks good.

Sure, thanks for the review!


- Naveen