linux-kernel - Re: [PATCH] pinctrl: mcp23s08: Get rid of spurious level interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbtjS54+g-K1azE2hHeTsiyzA_gFa2NBX6QZZ3D_H5Ryg@mail.gmail.com>
Date: Thu, 6 Feb 2025 10:25:51 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Dmitry Mastykin <mastichi@...il.com>, Sebastian Reichel <sre@...nel.org>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	e.shatokhin@...ro.com, arturas.moskvinas@...il.com
Subject: Re: [PATCH] pinctrl: mcp23s08: Get rid of spurious level interrupts

On Wed, Jan 22, 2025 at 1:05 PM Dmitry Mastykin <mastichi@...il.com> wrote:

> irq_mask()/irq_unmask() are not called for nested interrupts. So level
> interrupts are never masked, chip's interrupt output is not cleared on
> INTCAP or GPIO read, the irq handler is uselessly called again. Nested
> irq handler is not called again, because interrupt reason is cleared by
> its first call.
> /proc/interrupts shows that number of chip's irqs is greater than
> number of nested irqs.
>
> This patch adds masking and unmasking level interrupts inside irq handler.
>
> Signed-off-by: Dmitry Mastykin <mastichi@...il.com>

Patch tentatively applied as non-urgent fix.

If this is urgent, I need a Fixes: tags and we should also tag it
for stable, is this a big problem for users? I don't have the big picture
here.

Adding Sebastian, if he's still using this expander.

Yours,
Linus Walleij