linux-kernel - Re: [PATCH v1] f2fs: remove unnecessary null checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d5f02fbb-e100-4154-ab4a-cac47807cc38@kernel.org>
Date: Thu, 6 Feb 2025 09:59:05 +0800
From: Chao Yu <chao@...nel.org>
To: Kohei Enju <enjuk@...zon.com>, linux-f2fs-devel@...ts.sourceforge.net,
 linux-kernel@...r.kernel.org
Cc: chao@...nel.org, Jaegeuk Kim <jaegeuk@...nel.org>,
 Damien Le Moal <damien.lemoal@....com>,
 Chaitanya Kulkarni <chaitanya.kulkarni@....com>,
 Johannes Thumshirn <johannes.thumshirn@....com>, Jens Axboe
 <axboe@...nel.dk>, Kohei Enju <kohei.enju@...il.com>
Subject: Re: [PATCH v1] f2fs: remove unnecessary null checking

On 2/2/25 12:32, Kohei Enju wrote:
> When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is
> specified, bio_alloc_bioset() never fails to allocate a bio.
> Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced
> f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after
> bio_alloc_bioset() was still left.
> 
> Fixes: 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO")
> Signed-off-by: Kohei Enju <enjuk@...zon.com>

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,