linux-kernel - RE: [PATCH v11 8/8] iio: adc: ad4851: add ad485x driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CY4PR03MB3399B389972E92742EA3060D9BF62@CY4PR03MB3399.namprd03.prod.outlook.com>
Date: Thu, 6 Feb 2025 10:00:42 +0000
From: "Miclaus, Antoniu" <Antoniu.Miclaus@...log.com>
To: David Lechner <dlechner@...libre.com>,
        "jic23@...nel.org"
	<jic23@...nel.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "linux-iio@...r.kernel.org"
	<linux-iio@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-pwm@...r.kernel.org"
	<linux-pwm@...r.kernel.org>
Subject: RE: [PATCH v11 8/8] iio: adc: ad4851: add ad485x driver

> On 1/27/25 4:57 AM, Antoniu Miclaus wrote:
> > Add support for the AD485X a fully buffered, 8-channel simultaneous
> > sampling, 16/20-bit, 1 MSPS data acquisition system (DAS) with
> > differential, wide common-mode range inputs.
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> > ---
> 
> I think we have the important bits sorted now (i.e. userspace-facing stuff).
> Just noticed a few minor things in the latest revision.
> 
> 
> > +static int ad4851_setup(struct ad4851_state *st)
> > +{
> > +	unsigned int product_id;
> > +	int ret;
> > +
> > +	if (st->pd_gpio) {
> > +		/* To initiate a global reset, bring the PD pin high twice */
> > +		gpiod_set_value(st->pd_gpio, 1);
> > +		fsleep(1);
> > +		gpiod_set_value(st->pd_gpio, 0);
> > +		fsleep(1);
> > +		gpiod_set_value(st->pd_gpio, 1);
> > +		fsleep(1);
> > +		gpiod_set_value(st->pd_gpio, 0);
> > +		fsleep(1000);
> > +	} else {
> > +		ret = regmap_set_bits(st->regmap,
> AD4851_REG_INTERFACE_CONFIG_A,
> > +				      AD4851_SW_RESET);
> > +		if (ret)
> > +			return ret;
> 
> Do we also need fsleep() after software reset?
The datasheet doesn't mention any delay required after performing Software Reset.
Should I add something just as a safety measure?