linux-kernel - RE: [PATCH v2] arm64: dts: socfpga: agilex5: add NAND board file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL3PR11MB6532DF4347EE2187728CB0FFA2F62@BL3PR11MB6532.namprd11.prod.outlook.com>
Date: Thu, 6 Feb 2025 02:15:29 +0000
From: "Rabara, Niravkumar L" <niravkumar.l.rabara@...el.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Dinh Nguyen <dinguyen@...nel.org>,
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, "nirav.rabara@...era.com"
	<nirav.rabara@...era.com>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: socfpga: agilex5: add NAND board file

Hi Krysztof,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Thursday, 6 February, 2025 12:36 AM
> To: Rabara, Niravkumar L <niravkumar.l.rabara@...el.com>; Dinh Nguyen
> <dinguyen@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski
> <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>;
> nirav.rabara@...era.com; devicetree@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH v2] arm64: dts: socfpga: agilex5: add NAND board file
> 
> >>> +	model = "SoCFPGA Agilex5 SoCDK";
> >>> +	compatible = "intel,socfpga-agilex5-socdk",
> >>> +"intel,socfpga-agilex5";
> >>
> >>
> >> You cannot use other boards compatibles. Different device, different
> >> compatible.
> >>
> >
> > Same Agilex5 development kit board supports a separate NAND daughter
> > card.
> > Default daughter card with SDMMC on Agilex5 devkit required to
> > replaced with this NAND daughter card to use NAND flash with
> > Agilex5 devkit.
> 
> 
> So different boards?
> 
> >
> > Maybe I should replace the "NAND board" to "NAND daughter board"
> > for the patch title.
> >
> > Is this reasonable?
> 
> 
> Yeah, would be better, but I was not commenting about that. Define what is the
> hardware here and use proper compatibles.
> 

Got it.
I was under the wrong impression that daughter board can use the base board
compatibles.  

I will add the NAND board's compatible to the bindings and use it here
in v3.

Thanks,
Nirav