linux-kernel - Re: [PATCH v2 1/3] regulator: ad5398: change enable bit name to improve readibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae56f8b2-1ca5-463c-8a4e-a384ab0189f6@sirena.org.uk>
Date: Thu, 6 Feb 2025 11:30:13 +0000
From: Mark Brown <broonie@...nel.org>
To: Isaac Scott <isaac.scott@...asonboard.com>
Cc: Guenter Roeck <linux@...ck-us.net>, michael.hennerich@...log.com,
	lgirdwood@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] regulator: ad5398: change enable bit name to
 improve readibility

On Thu, Feb 06, 2025 at 09:59:13AM +0000, Isaac Scott wrote:
> On Wed, 2025-02-05 at 10:45 -0800, Guenter Roeck wrote:

> > 0x8000 is BIT(15).

> You're totally right! The reason this got through is because in my use
> case, I am powering the regulator on and off in multiple ways. This
> should definitely be BIT(15), so I will send a V3 shortly.

Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code.  Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)