linux-kernel - Re: [PATCH 1/2] PCI/portdrv: Add necessary delay for disabling hotplug events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6Qho7k_zj7NcA37@U-2FWC9VHC-2323.local>
Date: Thu, 6 Feb 2025 10:42:43 +0800
From: Feng Tang <feng.tang@...ux.alibaba.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	rafael.j.wysocki@...el.com
Subject: Re: [PATCH 1/2] PCI/portdrv: Add necessary delay for disabling
 hotplug events

Hi Markus,

Thanks for the review and reminding!

On Wed, Feb 05, 2025 at 06:48:35PM +0100, Markus Elfring wrote:
> …
> > Add the necessary wait to comply with PCIe spec. The waiting logic refers
> > existing pcie_poll_cmd().
> 
> * How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
 
The code went through some refactor, and the related commit should be:

	commit 2bd50dd800b52245294cfceb56be62020cdc7515
	Author: Rafael J. Wysocki <rjw@...ysocki.net>
	Date:   Sat Aug 21 01:57:39 2010 +0200

	    PCI: PCIe: Disable PCIe port services during port initialization
	    
	    In principle PCIe port services may be enabled by the BIOS, so it's
	    better to disable them during port initialization to avoid spurious
	    events from being generated.
	    
	    Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
	    Reviewed-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
	    Signed-off-by: Jesse Barnes <jbarnes@...tuousgeek.org>

Add Rafael to cc.

> * Will cover letters be usually helpful for such patch series?

Initially I planned to send the 2 patches seprately as they handle
different issues, but as 2/2 will reuse the helper function added
by 1/2, I put them together. 

> * You would probably like to avoid a typo in an email address.

Could you be more specific? I got the mail addresses from get_maintainers.pl.
thanks!

- Feng