linux-kernel - Re: [PATCH v1 22/29] cxl/region: Use translated HPA ranges to create a region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6S4PjcrnS-_Rog8@rric.localdomain>
Date: Thu, 6 Feb 2025 14:25:18 +0100
From: Robert Richter <rrichter@....com>
To: Gregory Price <gourry@...rry.net>
Cc: Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>,
	Ira Weiny <ira.weiny@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Dave Jiang <dave.jiang@...el.com>,
	Davidlohr Bueso <dave@...olabs.net>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"Fabio M. De Francesco" <fabio.m.de.francesco@...ux.intel.com>,
	Terry Bowman <terry.bowman@....com>
Subject: Re: [PATCH v1 22/29] cxl/region: Use translated HPA ranges to create
 a region

On 07.01.25 18:08:59, Gregory Price wrote:
> On Tue, Jan 07, 2025 at 03:10:08PM +0100, Robert Richter wrote:
> > To create a region, SPA ranges must be used. With address translation
> > the endpoint's HPA range is not the same as the SPA range. Use the
> > previously calculated SPA range instead.
> > 
> > Signed-off-by: Robert Richter <rrichter@....com>
> 
> Patches 22-25 seem reliant on each other.  Should I expect errors if I
> were to test them individually?
> 
> The individual changes in 22-24 seem ok, but is spa->* expected to be
> correct in the absense of the PRMT translation functions when HPA==SPA?

Exactly, as long as ->to_hpa() is not enabled, there is HPA==SPA and
code should work as before.

-Robert