linux-kernel - Re: [PATCH net-next v4 1/8] net: gro: decouple GRO from the NAPI layer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250205185645.51fd5f1f@kernel.org>
Date: Wed, 5 Feb 2025 18:56:45 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
 Lorenzo Bianconi <lorenzo@...nel.org>, Daniel Xu <dxu@...uu.xyz>, Alexei
 Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Andrii Nakryiko <andrii@...nel.org>, John Fastabend
 <john.fastabend@...il.com>, Toke Høiland-Jørgensen
 <toke@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>, Martin KaFai
 Lau <martin.lau@...ux.dev>, netdev@...r.kernel.org, bpf@...r.kernel.org,
 linux-kernel@...r.kernel.org, Toke Høiland-Jørgensen
 <toke@...hat.com>
Subject: Re: [PATCH net-next v4 1/8] net: gro: decouple GRO from the NAPI
 layer

On Wed, 5 Feb 2025 18:48:50 +0100 Eric Dumazet wrote:
> > +       struct_group_tagged(gro_node, gro,
> > +               unsigned long           bitmask;
> > +               struct gro_list         hash[GRO_HASH_BUCKETS];
> > +               struct list_head        rx_list; /* Pending GRO_NORMAL skbs */
> > +               int                     rx_count; /* length of rx_list */
> > +               u32                     napi_id; /* protected by netdev_lock */
> > +  
> 
> I am old school, I would prefer a proper/standalone old C construct.

+1, fwiw, I thought it was just me..