linux-kernel - Re: [PATCH v5] serial: sh-sci: Update the suspend/resume support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVTifmJ82geKC5Ta2yM-uH6dFZab1_Tc_vTDWzZ3o4D1w@mail.gmail.com>
Date: Thu, 6 Feb 2025 14:55:11 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Claudiu <claudiu.beznea@...on.dev>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org, p.zabel@...gutronix.de, 
	wsa+renesas@...g-engineering.com, prabhakar.mahadev-lad.rj@...renesas.com, 
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH v5] serial: sh-sci: Update the suspend/resume support

Hi Claudiu,

On Thu, 6 Feb 2025 at 13:47, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> On Wed, 5 Feb 2025 at 10:31, Claudiu <claudiu.beznea@...on.dev> wrote:
> > @@ -3546,13 +3559,41 @@ static int sci_probe(struct platform_device *dev)
> >         return 0;
> >  }
> >
> > +static void sci_console_save_restore(struct sci_port *s, bool save)
> > +{
> > +       struct sci_suspend_regs *regs = &s->suspend_regs;
> > +       struct uart_port *port = &s->port;
> > +
> > +       if (save) {
> > +               regs->scsmr = sci_serial_in(port, SCSMR);
> > +               regs->scscr = sci_serial_in(port, SCSCR);
> > +               regs->scfcr = sci_serial_in(port, SCFCR);
> > +               regs->scsptr = sci_serial_in(port, SCSPTR);
> > +               regs->scbrr = sci_serial_in(port, SCBRR);
> > +               regs->semr = sci_serial_in(port, SEMR);
>
> The SCFCR, SCSPTR, and SEMR registers do not exist on all
> variants.  Hence you should call sci_getreg() and check if
> plat_sci_reg.size is non-zero first, else you will trigger the WARN()
> in sci_serial_in().

As expected, the WARN() is triggered on any R-Car platform during
system suspend.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds