| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <456d92e10e8fd8d58cd524878902790fbc789850.camel@mediatek.com>
Date: Fri, 7 Feb 2025 02:15:07 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
"raphael.gallais-pou@...s.st.com" <raphael.gallais-pou@...s.st.com>,
"mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>,
"zhang.lyra@...il.com" <zhang.lyra@...il.com>, "andy.yan@...k-chips.com"
<andy.yan@...k-chips.com>, "chunkuang.hu@...nel.org"
<chunkuang.hu@...nel.org>, "kong.kongxinwei@...ilicon.com"
<kong.kongxinwei@...ilicon.com>, "alexandre.torgue@...s.st.com"
<alexandre.torgue@...s.st.com>, AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>, "mripard@...nel.org"
<mripard@...nel.org>, "andrew@...econstruct.com.au"
<andrew@...econstruct.com.au>, "heiko@...ech.de" <heiko@...ech.de>,
"jonathanh@...dia.com" <jonathanh@...dia.com>, "shawnguo@...nel.org"
<shawnguo@...nel.org>, "asrivats@...hat.com" <asrivats@...hat.com>,
"philippe.cornu@...s.st.com" <philippe.cornu@...s.st.com>, "stefan@...er.ch"
<stefan@...er.ch>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"abrodkin@...opsys.com" <abrodkin@...opsys.com>, "sumit.semwal@...aro.org"
<sumit.semwal@...aro.org>, "corbet@....net" <corbet@....net>,
"kernel-list@...pberrypi.com" <kernel-list@...pberrypi.com>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>, "mcanal@...lia.com"
<mcanal@...lia.com>, "tiantao6@...ilicon.com" <tiantao6@...ilicon.com>,
"jstultz@...gle.com" <jstultz@...gle.com>, "mperttunen@...dia.com"
<mperttunen@...dia.com>, "thierry.reding@...il.com"
<thierry.reding@...il.com>, "yannick.fertre@...s.st.com"
<yannick.fertre@...s.st.com>, "baolin.wang@...ux.alibaba.com"
<baolin.wang@...ux.alibaba.com>, "simona@...ll.ch" <simona@...ll.ch>,
"airlied@...il.com" <airlied@...il.com>, "kernel@...gutronix.de"
<kernel@...gutronix.de>, "orsonzhai@...il.com" <orsonzhai@...il.com>,
"alison.wang@....com" <alison.wang@....com>, "marex@...x.de" <marex@...x.de>,
"xinliang.liu@...aro.org" <xinliang.liu@...aro.org>, "joel@....id.au"
<joel@....id.au>, "rgallaispou@...il.com" <rgallaispou@...il.com>,
"festevam@...il.com" <festevam@...il.com>, "dave.stevenson@...pberrypi.com"
<dave.stevenson@...pberrypi.com>, "yongqin.liu@...aro.org"
<yongqin.liu@...aro.org>, "maarten.lankhorst@...ux.intel.com"
<maarten.lankhorst@...ux.intel.com>, "alain.volmat@...s.st.com"
<alain.volmat@...s.st.com>, "hjc@...k-chips.com" <hjc@...k-chips.com>,
"tzimmermann@...e.de" <tzimmermann@...e.de>
CC: "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-stm32@...md-mailman.stormreply.com"
<linux-stm32@...md-mailman.stormreply.com>,
"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
"imx@...ts.linux.dev" <imx@...ts.linux.dev>,
"linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH 04/12] drm/mediatek: move to
devm_platform_ioremap_resource() usage
Hi, Anusha:
On Wed, 2025-02-05 at 15:08 -0500, Anusha Srivatsa wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
>
>
> Replace platform_get_resource + devm_ioremap_resource
> with just devm_platform_ioremap_resource()
>
> Used Coccinelle to do this change. SmPl patch:
> @rule_1@
> identifier res;
> expression ioremap_res;
> identifier pdev;
> @@
> -struct resource *res;
> ...
> -res = platform_get_resource(pdev,...);
> -ioremap_res = devm_ioremap_resource(...);
> +ioremap_res = devm_platform_ioremap_resource(pdev,0);
Reviewed-by: CK Hu <ck.hu@...iatek.com>
>
> Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Signed-off-by: Anusha Srivatsa <asrivats@...hat.com>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_color.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_disp_merge.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 +---
> drivers/gpu/drm/mediatek/mtk_mdp_rdma.c | 4 +---
> 8 files changed, 8 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c b/drivers/gpu/drm/mediatek/mtk_disp_color.c
> index dd8433a38282a9ba1bcc3a4ddd01dd89738ccb60..39c7de4cdcc16b56a5a1d046aaabaf5580227ed2 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_color.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_color.c
> @@ -96,7 +96,6 @@ static int mtk_disp_color_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct mtk_disp_color *priv;
> - struct resource *res;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -108,8 +107,7 @@ static int mtk_disp_color_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->clk),
> "failed to get color clk\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap color\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
> index b17b11d93846f2019d8c4afb294375333e22dc42..8afd15006df2a21f3f52fe00eca3c5501f4fb76a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
> @@ -256,7 +256,6 @@ static int mtk_disp_gamma_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct mtk_disp_gamma *priv;
> - struct resource *res;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -268,8 +267,7 @@ static int mtk_disp_gamma_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->clk),
> "failed to get gamma clk\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap gamma\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_merge.c b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
> index 563b1b248fbbb38ef03bb3e3ceecdd265961df60..b174dda091d3fbd16796e8e128b030fccf5b902c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_merge.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_merge.c
> @@ -306,7 +306,6 @@ static const struct component_ops mtk_disp_merge_component_ops = {
> static int mtk_disp_merge_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *res;
> struct mtk_disp_merge *priv;
> int ret;
>
> @@ -314,8 +313,7 @@ static int mtk_disp_merge_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap merge\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> index df82cea4bb79c472acbb66e0df27fbad3e70bd20..d0581c4e3c999cf865fdd0aaf4c2f38dd404926e 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c
> @@ -604,7 +604,6 @@ static int mtk_disp_ovl_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct mtk_disp_ovl *priv;
> - struct resource *res;
> int irq;
> int ret;
>
> @@ -621,8 +620,7 @@ static int mtk_disp_ovl_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->clk),
> "failed to get ovl clk\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap ovl\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> index bf47790e4d6be5d60070c63c15c75fa201cc4b27..c9d41d75e7f2a3af5820921b7e563da377ce8d0d 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> @@ -313,7 +313,6 @@ static int mtk_disp_rdma_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct mtk_disp_rdma *priv;
> - struct resource *res;
> int irq;
> int ret;
>
> @@ -330,8 +329,7 @@ static int mtk_disp_rdma_probe(struct platform_device *pdev)
> return dev_err_probe(dev, PTR_ERR(priv->clk),
> "failed to get rdma clk\n");
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap rdma\n");
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index 40752f2320548fbf6c7de96b18e8a636ac9c31be..f298293471de49473dd05973383dc22f7d3b6c23 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1192,7 +1192,6 @@ static int mtk_dsi_probe(struct platform_device *pdev)
> {
> struct mtk_dsi *dsi;
> struct device *dev = &pdev->dev;
> - struct resource *regs;
> int irq_num;
> int ret;
>
> @@ -1217,8 +1216,7 @@ static int mtk_dsi_probe(struct platform_device *pdev)
> if (IS_ERR(dsi->hs_clk))
> return dev_err_probe(dev, PTR_ERR(dsi->hs_clk), "Failed to get hs clock\n");
>
> - regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dsi->regs = devm_ioremap_resource(dev, regs);
> + dsi->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dsi->regs))
> return dev_err_probe(dev, PTR_ERR(dsi->regs), "Failed to ioremap memory\n");
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> index ca82bc829cb96446d4d34eeef45848df03bd716b..d729c13590cb5ec176f15b680c262a26b677e6aa 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
> @@ -1425,7 +1425,6 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi,
> struct device_node *cec_np, *remote, *i2c_np;
> struct platform_device *cec_pdev;
> struct regmap *regmap;
> - struct resource *mem;
> int ret;
>
> ret = mtk_hdmi_get_all_clk(hdmi, np);
> @@ -1471,8 +1470,7 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi,
> }
> hdmi->sys_regmap = regmap;
>
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - hdmi->regs = devm_ioremap_resource(dev, mem);
> + hdmi->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(hdmi->regs)) {
> ret = PTR_ERR(hdmi->regs);
> goto put_device;
> diff --git a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> index fc69ee38ce7d6a245a7460cfde8de426e83b2e80..7982788ae9df51f1a378d8d538737f38af7299f2 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_mdp_rdma.c
> @@ -291,7 +291,6 @@ static const struct component_ops mtk_mdp_rdma_component_ops = {
> static int mtk_mdp_rdma_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> - struct resource *res;
> struct mtk_mdp_rdma *priv;
> int ret = 0;
>
> @@ -299,8 +298,7 @@ static int mtk_mdp_rdma_probe(struct platform_device *pdev)
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->regs))
> return dev_err_probe(dev, PTR_ERR(priv->regs),
> "failed to ioremap rdma\n");
>
> --
> 2.47.0
>
>
Powered by blists - more mailing lists