linux-kernel - Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on PineNote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <502523554b482a2e10d85d37761932a0@manjaro.org>
Date: Fri, 07 Feb 2025 16:01:04 +0100
From: Dragan Simic <dsimic@...jaro.org>
To: Diederik de Haas <didi.debian@...ow.org>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Maximilian Weigand <mweigand@...igand.net>, Marek Kraus <gamiee@...e64.org>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] arm64: dts: rockchip: add 'chassis-type' property on
 PineNote

Hello Diederik,

On 2025-02-07 12:11, Diederik de Haas wrote:
> Add the recommended chassis-type root node property so userspace can
> request the form factor and adjust their behavior accordingly.
> 
> Signed-off-by: Diederik de Haas <didi.debian@...ow.org>
> Link: 
> https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter3-devicenodes.rst#root-node

Maybe the Link tag should be converted into a "[1]" reference?
To me, this is more like a reference for this DT addition.

In general, references can also be placed closer to the contents
they back up, which isn't possible with Link tags, but of course
that doesn't matter much in this case.

> ---
>  arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> index 2d3ae1544822..3613661417b2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
> @@ -9,6 +9,8 @@
>  #include "rk3566.dtsi"
> 
>  / {
> +	chassis-type = "tablet";
> +
>  	aliases {
>  		mmc0 = &sdhci;
>  	};

The patch is obviously fine.  Thanks for the patch, and please feel
free to include, regardless of the note above, my:

Reviewed-by: Dragan Simic <dsimic@...jaro.org>