linux-kernel - Re: [PATCH v2 1/2] scsi: qedf: Replace kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025020721-silver-uneasy-5565@gregkh>
Date: Fri, 7 Feb 2025 16:09:58 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Jiasheng Jiang <jiashengjiangcool@...il.com>
Cc: GR-QLogic-Storage-Upstream@...vell.com,
	James.Bottomley@...senpartnership.com, arun.easi@...ium.com,
	bvanassche@....org, jhasan@...vell.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	manish.rangankar@...ium.com, markus.elfring@....de,
	martin.petersen@...cle.com, nilesh.javali@...ium.com,
	skashyap@...vell.com, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc()

On Thu, Feb 06, 2025 at 07:19:59PM +0000, Jiasheng Jiang wrote:
> Replace kmalloc_array() with kcalloc() to avoid old (dirty) data being
> used/freed.

"Potentially" being freed.  It will not be used.  And this is only for
an error path that obviously no one has hit before.

Please explain this much better.

thanks,

greg k-h