linux-kernel - Re: [PATCH v9 11/14] platform/x86: Split the alienware-wmi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D7MBDPIDK7XS.3DONIQK22EIBH@gmail.com>
Date: Fri, 07 Feb 2025 10:21:24 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: <platform-driver-x86@...r.kernel.org>, "Armin Wolf" <W_Armin@....de>,
 "Mario Limonciello" <mario.limonciello@....com>, "Hans de Goede"
 <hdegoede@...hat.com>, <Dell.Client.Kernel@...l.com>, "LKML"
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 11/14] platform/x86: Split the alienware-wmi driver

On Fri Feb 7, 2025 at 10:05 AM -05, Ilpo Järvinen wrote:
> On Fri, 7 Feb 2025, Kurt Borja wrote:
>
>> Split alienware-wmi WMI drivers into different files. This is done
>> seamlessly by copying and pasting, however some blocks are reordered.
>> 
>> Reviewed-by: Armin Wolf <W_Armin@....de>
>> Reviewed-by: Mario Limonciello <mario.limonciello@....com>
>> Signed-off-by: Kurt Borja <kuurtb@...il.com>
>
> Hi,
>
> Can you please check there's no error in driver_data assignments as the 
> numbers in removed & added lines do not match:

Hi Ilpo,

There was indeed a wrong assignment to Alienware m16 r1 AMD, I'm not
really sure how it happened but it's fixed now!

I'll send a v10. I apologize for the noise.

>
> $ git diff-tree -p 73224c076cf2fa2968d61584c62937f6180c8e71 | grep driver_data | rev | sort | rev | uniq -c

Thanks for this amazing trick btw.

~ Kurt

>       1 +               awcc = id->driver_data;
>       1 -               awcc = id->driver_data;
>       4 +               .driver_data = &generic_quirks,
>       5 -               .driver_data = &generic_quirks,
>       7 +               .driver_data = &g_series_quirks,
>       6 -               .driver_data = &g_series_quirks,
>
> (That commit id is from my staging tree, not available to you but it's 
> this patch.)