linux-kernel - Re: [PATCH v5 25/40] x86/resctrl: Make prefetch_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20de5d61-c50d-45b2-bd6e-6a200d250237@arm.com>
Date: Fri, 7 Feb 2025 15:46:20 +0000
From: James Morse <james.morse@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Fenghua Yu <fenghua.yu@...el.com>, Thomas Gleixner <tglx@...utronix.de>,
 Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
 H Peter Anvin <hpa@...or.com>, Babu Moger <Babu.Moger@....com>,
 shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Shaopeng Tan <tan.shaopeng@...fujitsu.com>
Subject: Re: [PATCH v5 25/40] x86/resctrl: Make prefetch_disable_bits belong
 to the arch code

Hi Reinette,

On 23/10/2024 23:53, Reinette Chatre wrote:
> On 10/4/24 11:03 AM, James Morse wrote:
>> prefetch_disable_bits is set by rdtgroup_locksetup_enter() from a
>> value provided by the architecture, but is largely read by other
>> architecture helpers.
>>
>> Instead of exporting this value, make
>> resctrl_arch_get_prefetch_disable_bits() set it so that the other
>> arch-code helpers can use the cached-value.
> 
> The "exporting" term has already caused some confusion. How about:
> 
> Make resctrl_arch_get_prefetch_disable_bits() set prefetch_disable_bits
> so that it can be isolated to arch-code from where the other arch-code
> helpers can use its cached-value.
> 
> (Please feel free to improve.)

I'd cleaned those up - but I'll go with your version as it'll be in the
correct voice.


Thanks,

James