linux-kernel - Re: [PATCH v2 1/2] scsi: qedf: Replace kmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANeGvZX8F-TGn0tfuLqUMFN89aepML6mtAvvSjRJyysvUDzGhg@mail.gmail.com>
Date: Fri, 7 Feb 2025 10:46:16 -0500
From: Jiasheng Jiang <jiashengjiangcool@...il.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: GR-QLogic-Storage-Upstream@...vell.com, 
	James.Bottomley@...senpartnership.com, arun.easi@...ium.com, 
	bvanassche@....org, jhasan@...vell.com, linux-kernel@...r.kernel.org, 
	linux-scsi@...r.kernel.org, manish.rangankar@...ium.com, 
	markus.elfring@....de, martin.petersen@...cle.com, nilesh.javali@...ium.com, 
	skashyap@...vell.com, stable@...r.kernel.org
Subject: Re: [PATCH v2 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc()

Hi Greg,

On Fri, Feb 7, 2025 at 10:10 AM Greg KH <gregkh@...uxfoundation.org> wrote:
>
> On Thu, Feb 06, 2025 at 07:19:59PM +0000, Jiasheng Jiang wrote:
> > Replace kmalloc_array() with kcalloc() to avoid old (dirty) data being
> > used/freed.
>
> "Potentially" being freed.  It will not be used.  And this is only for
> an error path that obviously no one has hit before.
>
> Please explain this much better.
>
> thanks,
>
> greg k-h

Thanks, I have submitted a v3 and added "potentially" in the commit message.

-Jiasheng