linux-kernel - Re: [PATCH v2] intel_idle: introduce 'no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c258775cdf2f8f3c370c0cb81daf22dacf6aeed.camel@gmail.com>
Date: Fri, 07 Feb 2025 17:55:22 +0200
From: Artem Bityutskiy <dedekind1@...il.com>
To: David Arcari <darcari@...hat.com>, linux-pm@...r.kernel.org
Cc: Jonathan Corbet <corbet@....net>, Jacob Pan
 <jacob.jun.pan@...ux.intel.com>,  Len Brown <lenb@...nel.org>, Prarit
 Bhargava <prarit@...hat.com>, linux-doc@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] intel_idle: introduce 'no_native' module parameter

Hi David,

On Thu, 2025-02-06 at 11:40 -0500, David Arcari wrote:
> +The ``no_acpi``, ``use_acpi`` and ``no_native`` module parameters are
> +recognized by ``intel_idle`` if the kernel has been configured with ACPI
> +support).

And if kernel was not configured with ACPI support, are these not recognized? Or
they are just no-op basically?

Looks like there is a stray ")" at the end.

> +
> +``no_acpi`` - Do not use ACPI at all.  Only native mode is available, no
> +ACPI mode.
> +
> +``use_acpi`` - No-op in ACPI mode; however, the driver will consult ACPI
> +tables for C-states on/off status in native mode.

I think "however" part is a bit confusing. Would you consider re-phrasing
without "however" ?

> +
> +``no_native`` - Work only in ACPI mode, no native mode available (ignore
> +all custom tables).

Other than these small nitpicks,

Reviewed-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
Tested-by: Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>

(I tested it on an Intel Broadwell platform).

Thanks!