linux-kernel - Re: [PATCH] drm/mediatek: Convert to use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17d991fd6b45b11f215d976bd702251ceb994bcf.camel@mediatek.com>
Date: Fri, 7 Feb 2025 02:26:41 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "oushixiong1025@....com" <oushixiong1025@....com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC: "simona@...ll.ch" <simona@...ll.ch>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "airlied@...il.com" <airlied@...il.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "p.zabel@...gutronix.de"
	<p.zabel@...gutronix.de>, "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"oushixiong@...inos.cn" <oushixiong@...inos.cn>
Subject: Re: [PATCH] drm/mediatek: Convert to use
 devm_platform_ioremap_resource

Hi, Shixiong:

On Tue, 2025-01-28 at 17:41 +0800, oushixiong1025@....com wrote:
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> 
> 
> From: Shixiong Ou <oushixiong@...inos.cn>
> 
> Do not need to get resource, so convert to use
> devm_platform_ioremap_resource.

Reviewed-by: CK Hu <ck.hu@...iatek.com>

> 
> Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>
> ---
>  drivers/gpu/drm/mediatek/mtk_padding.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_padding.c b/drivers/gpu/drm/mediatek/mtk_padding.c
> index b4e3e5a3428b..7e302724e74a 100644
> --- a/drivers/gpu/drm/mediatek/mtk_padding.c
> +++ b/drivers/gpu/drm/mediatek/mtk_padding.c
> @@ -95,7 +95,6 @@ static int mtk_padding_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
>         struct mtk_padding *priv;
> -       struct resource *res;
>         int ret;
> 
>         priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -107,7 +106,7 @@ static int mtk_padding_probe(struct platform_device *pdev)
>                 return dev_err_probe(dev, PTR_ERR(priv->clk),
>                                      "failed to get clk\n");
> 
> -       priv->reg = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
> +       priv->reg = devm_platform_ioremap_resource(pdev, 0);
>         if (IS_ERR(priv->reg))
>                 return dev_err_probe(dev, PTR_ERR(priv->reg),
>                                      "failed to do ioremap\n");
> --
> 2.43.0
> 
>