linux-kernel - RE: [EXTERNAL] [PATCH next] RDMA/mana

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA6PR21MB42317A411C6A2309ADD73493CEF12@SA6PR21MB4231.namprd21.prod.outlook.com>
Date: Fri, 7 Feb 2025 17:26:39 +0000
From: Long Li <longli@...rosoft.com>
To: Dan Carpenter <dan.carpenter@...aro.org>, Konstantin Taranov
	<kotaranov@...rosoft.com>
CC: Ajay Sharma <sharmaajay@...rosoft.com>, Jason Gunthorpe <jgg@...pe.ca>,
	Leon Romanovsky <leon@...nel.org>, Shiraz Saleem
	<shirazsaleem@...rosoft.com>, "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH next] RDMA/mana_ib: Fix error code in probe()

> Return -ENOMEM if dma_pool_create() fails.  Don't return success.
> 
> Fixes: df91c470d9e5 ("RDMA/mana_ib: create/destroy AH")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thank you!

Reviewed-by: Long Li <longli@...rosoft.com>

> ---
>  drivers/infiniband/hw/mana/device.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mana/device.c
> b/drivers/infiniband/hw/mana/device.c
> index 0a7553f819ba..a17e7a6b0545 100644
> --- a/drivers/infiniband/hw/mana/device.c
> +++ b/drivers/infiniband/hw/mana/device.c
> @@ -144,8 +144,10 @@ static int mana_ib_probe(struct auxiliary_device *adev,
> 
>  	dev->av_pool = dma_pool_create("mana_ib_av", mdev->gdma_context-
> >dev,
>  				       MANA_AV_BUFFER_SIZE,
> MANA_AV_BUFFER_SIZE, 0);
> -	if (!dev->av_pool)
> +	if (!dev->av_pool) {
> +		ret = -ENOMEM;
>  		goto destroy_rnic;
> +	}
> 
>  	ret = ib_register_device(&dev->ib_dev, "mana_%d",
>  				 mdev->gdma_context->dev);
> --
> 2.47.2