linux-kernel - Re: [PATCH v2] hwmon: (xgene-hwmon) use appropriate type for the latency value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aedbefb8-7979-4482-a2af-e12eda4a4b6f@roeck-us.net>
Date: Thu, 6 Feb 2025 18:52:54 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Ваторопин Андрей <a.vatoropin@...t.ru>
Cc: Jean Delvare <jdelvare@...e.com>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>
Subject: Re: [PATCH v2] hwmon: (xgene-hwmon) use appropriate type for the
 latency value

On Tue, Feb 04, 2025 at 09:54:08AM +0000, Ваторопин Андрей wrote:
> From: Andrey Vatoropin <a.vatoropin@...t.ru>
> 
> The expression PCC_NUM_RETRIES * pcc_chan->latency is currently being
> evaluated using 32-bit arithmetic.
> 
> Since a value of type 'u64' is used to store the eventual result,
> and this result is later sent to the function usecs_to_jiffies with 
> input parameter unsigned int, the current data type is too wide to 
> store the value of ctx->usecs_lat.
> 
> Change the data type of "usecs_lat" to a more suitable (narrower) type.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Andrey Vatoropin <a.vatoropin@...t.ru>

Applied.

Thanks,
Guenter