linux-kernel - Re: [PATCH v9 00/12] AMD broadcast TLB invalidation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250207182336.1839092-1-jackmanb@google.com>
Date: Fri,  7 Feb 2025 18:23:36 +0000
From: Brendan Jackman <jackmanb@...gle.com>
To: riel@...riel.com
Cc: akpm@...ux-foundation.org, andrew.cooper3@...rix.com, bp@...en8.de, 
	dave.hansen@...ux.intel.com, jannh@...gle.com, kernel-team@...a.com, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, mhklinux@...look.com, 
	nadav.amit@...il.com, peterz@...radead.org, thomas.lendacky@....com, 
	x86@...nel.org, zhengqi.arch@...edance.com, 
	Brendan Jackman <jackmanb@...gle.com>
Subject: Re: [PATCH v9 00/12] AMD broadcast TLB invalidation

> Add support for broadcast TLB invalidation using AMD's INVLPGB instruction.

I applied this to 60675d4ca1ef0 ("Merge branch 'linus' into x86/mm, to pick up
fixes"), booted it and ran some selftests on a Milan and a Genoa machine, no
issues, although I didn't have CONFIG_DEBUG_VM or anything like that. I did see
the warning reported by Oleksandr [0] on QEMU.

I tried to test Turin but there's some unrelated brokenness. Due to other
unrelated issues I also couldn't test with lockdep.

Anyway I guess that counts as:

Tested-by: Brendan Jackman <jackmanb@...gle.com>

I couldn't get any performance data either, more unrelated brokenness. Maybe I
can try again next week.

I posted some bikeshed review comments but I haven't grokked the interesting
bits yet, will try to do that next week too.

[0] https://lore.kernel.org/linux-kernel/12602226.O9o76ZdvQC@natalenko.name/

Cheers,
Brendan