linux-kernel - Re: [PATCH] kselftest/arm64: Fix uninitialized variable warning in FPMR test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ba0dddf4-e4e4-482b-95f3-52eb4e31a643@sirena.org.uk>
Date: Fri, 7 Feb 2025 19:04:57 +0000
From: Mark Brown <broonie@...ian.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will@...nel.org>, Shuah Khan <shuah@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kselftest/arm64: Fix uninitialized variable warning in
 FPMR test

On Fri, Feb 07, 2025 at 10:45:39AM -0800, Breno Leitao wrote:
> On Fri, Feb 07, 2025 at 05:26:06PM +0000, Mark Brown wrote:
> > On Fri, Feb 07, 2025 at 03:06:42AM -0800, Breno Leitao wrote:
> > > Fix compiler warning about potentially uninitialized orig_fpmr variable:

> > > 	testcases/fpmr_siginfo.c: In function ‘fpmr_present’:
> > > 	testcases/fpmr_siginfo.c:68:25: warning: ‘orig_fpmr’ may be used uninitialized in this function [-Wmaybe-uninitialized]

> > This seems like something that should be reported to the compiler
> > people, we only print the FPMR value if have_fpmr and there's an
> > assignment to orig_fpmr in that case.  Which compiler is this?

> Good point. I am using:
> 	# gcc --version
> 	gcc (GCC) 11.5.0 20240719 (Red Hat 11.5.0-2)

> Clang, on the other hand, isn't upset about it.

Right, and I'm not seeing it here either.  I'm not opposed to applying
the patch if enough people are using toolchains that have the issue, but
these sorts of sledgehammer assignments aren't ideal since they mask
issues.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)