linux-kernel - Re: [PATCH v2] ata: libahci_platform: support non-consecutive port numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb8175c2755557dd6532ee71d1064241a1412ce2.camel@gmail.com>
Date: Fri, 07 Feb 2025 20:45:15 +0100
From: Klaus Kudielka <klaus.kudielka@...il.com>
To: Josua Mayer <josua@...id-run.com>, Damien Le Moal <dlemoal@...nel.org>, 
 Niklas Cassel <cassel@...nel.org>, Hans de Goede <hdegoede@...hat.com>
Cc: Jon Nettleton <jon@...id-run.com>, Mikhail Anikin	
 <mikhail.anikin@...id-run.com>, Yazan Shhady <yazan.shhady@...id-run.com>, 
 Rabeeh Khoury <rabeeh@...id-run.com>, "linux-ide@...r.kernel.org"
 <linux-ide@...r.kernel.org>,  "linux-kernel@...r.kernel.org"	
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ata: libahci_platform: support non-consecutive port
 numbers

On Fri, 2025-02-07 at 11:22 +0000, Josua Mayer wrote:
> 
> Can you confirm the physical number of sata ports on your board?
> 

The second port indeed seems not wired on Turris Omnia.
If the "masking port_map 0x3 -> 0x1" kernel warning had not suddenly appeared, I would not have noticed this at all.

> I would be curious whether in another board that has two ports physically,
> whether both of them were functional before my patch.

I don't have such a board, but to me it seems the existing code was made exactly for that case.

For reference, my board later reports
  ata2: SATA link down (SStatus 0 SControl 300)
  ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)

Best regards, Klaus