linux-kernel - Re: [PATCH] gpiolib: add missing include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfSr4CN_3GABi_NH0W4ACg4UU7KUBJ-NoUdXQ6Ou-FboQ@mail.gmail.com>
Date: Fri, 7 Feb 2025 21:33:02 +0100
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH] gpiolib: add missing include

On Fri, Feb 7, 2025 at 9:30 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> With some randconfigs I'm seeing the following error:
>
> In file included from drivers/gpio/gpiolib-swnode.c:19:
> ./include/linux/gpio/consumer.h: In function ‘gpiod_enable_hw_timestamp_ns’:
> ./include/linux/gpio/consumer.h:557:17: error: implicit declaration of function ‘WARN_ON’ [-Wimplicit-function-declaration]
>   557 |                 WARN_ON(desc);
>       |                 ^~~~~~~
>
> Pull in bug.h to fix it.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
>  include/linux/gpio/consumer.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
> index db2dfbae8edb..0b1acd014186 100644
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
> @@ -3,6 +3,7 @@
>  #define __LINUX_GPIO_CONSUMER_H
>
>  #include <linux/bits.h>
> +#include <linux/bug.h>
>  #include <linux/types.h>
>
>  struct acpi_device;
> --
> 2.45.2
>

Ah, build bot responding to my CONFIG_HTE patch made me realize we
already include asm/bug.h for !CONFIG_GPIOLIB. I'll rethink the
approach here as we'll need it for the HTE stubs too.

Bart