linux-kernel - Re: [PATCH v7 03/24] perf vendor events: Add Arrowlake events/metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0990a674-d8ab-4abc-a904-299513773f90@linux.intel.com>
Date: Fri, 7 Feb 2025 15:44:08 -0500
From: "Liang, Kan" <kan.liang@...ux.intel.com>
To: Ian Rogers <irogers@...gle.com>, Peter Zijlstra <peterz@...radead.org>,
 Ingo Molnar <mingo@...hat.com>, Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Adrian Hunter <adrian.hunter@...el.com>,
 Andreas Färber <afaerber@...e.de>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Weilin Wang <weilin.wang@...el.com>, linux-kernel@...r.kernel.org,
 linux-perf-users@...r.kernel.org, Perry Taylor <perry.taylor@...el.com>,
 Samantha Alt <samantha.alt@...el.com>,
 Caleb Biggers <caleb.biggers@...el.com>,
 Edward Baker <edward.baker@...el.com>, Michael Petlan <mpetlan@...hat.com>,
 Thomas Falcon <thomas.falcon@...el.com>
Subject: Re: [PATCH v7 03/24] perf vendor events: Add Arrowlake events/metrics



On 2025-02-07 1:51 p.m., Ian Rogers wrote:
> +    {
> +        "BriefDescription": "Percentage of time that the core is stalled due to a TPAUSE or UMWAIT instruction",
> +        "MetricExpr": "100 * cpu_atom@...IALIZATION.C01_MS_SCB@ / (8 * cpu_atom@..._CLK_UNHALTED.CORE@)",
> +        "MetricName": "tma_info_serialization _%_tpause_cycles",

It doesn't seem a correct MetricName. A convert script bug?

> +        "Unit": "cpu_atom"
> +    },diff --git a/tools/perf/pmu-events/arch/x86/arrowlake/uncore-other.json b/tools/perf/pmu-events/arch/x86/arrowlake/uncore-other.json
> new file mode 100644
> index 000000000000..1ac5b5ef8094
> --- /dev/null
> +++ b/tools/perf/pmu-events/arch/x86/arrowlake/uncore-other.json
> @@ -0,0 +1,10 @@
> +[
> +    {
> +        "BriefDescription": "This 48-bit fixed counter counts the UCLK cycles.",
> +        "Counter": "FIXED",
> +        "EventCode": "0xff",
> +        "EventName": "UNC_CLOCK.SOCKET",
> +        "PerPkg": "1",
> +        "Unit": "CLOCK"

On MTL and ARL, the unit should be CNCU.
Thomas will propose a convertor script patch to fix it.

Thanks,
Kan

> +    }
> +]