linux-kernel - Re: [PATCH v3 2/2] lsm,io_uring: add LSM hooks for io_uring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6aA0cWte6rZQSbo@hm-sls2>
Date: Fri, 7 Feb 2025 16:53:21 -0500
From: Hamza Mahfooz <hamzamahfooz@...ux.microsoft.com>
To: Paul Moore <paul@...l-moore.com>
Cc: linux-kernel@...r.kernel.org, James Morris <jmorris@...ei.org>,
	"Serge E. Hallyn" <serge@...lyn.com>, Jens Axboe <axboe@...nel.dk>,
	Pavel Begunkov <asml.silence@...il.com>,
	Stephen Smalley <stephen.smalley.work@...il.com>,
	Ondrej Mosnacek <omosnace@...hat.com>,
	Bram Bonné <brambonne@...gle.com>,
	Thiébaud Weksteen <tweek@...gle.com>,
	Christian Göttsche <cgzones@...glemail.com>,
	Masahiro Yamada <masahiroy@...nel.org>,
	linux-security-module@...r.kernel.org, io-uring@...r.kernel.org,
	selinux@...r.kernel.org
Subject: Re: [PATCH v3 2/2] lsm,io_uring: add LSM hooks for io_uring_setup()

On Fri, Feb 07, 2025 at 04:42:57PM -0500, Paul Moore wrote:
> On Jan 27, 2025 Hamza Mahfooz <hamzamahfooz@...ux.microsoft.com> wrote:
> > 
> > It is desirable to allow LSM to configure accessibility to io_uring
> > because it is a coarse yet very simple way to restrict access to it. So,
> > add an LSM for io_uring_allowed() to guard access to io_uring.
> > 
> > Cc: Paul Moore <paul@...l-moore.com>
> > Signed-off-by: Hamza Mahfooz <hamzamahfooz@...ux.microsoft.com>
> > ---
> >  include/linux/lsm_hook_defs.h       |  1 +
> >  include/linux/security.h            |  5 +++++
> >  io_uring/io_uring.c                 |  2 +-
> >  security/security.c                 | 12 ++++++++++++
> >  security/selinux/hooks.c            | 14 ++++++++++++++
> >  security/selinux/include/classmap.h |  2 +-
> >  6 files changed, 34 insertions(+), 2 deletions(-)
> 
> Thanks Hamza, this looks good to me, but we need to wait until we get an
> ACK from Jens on path 1/2; he's pretty responsive so I don't think we'll
> have to wait too long.
> 
> As far as the return/label issue in patch 1/2, as long as there are no
> other issues, and you are okay with the change, I can fix that up when
> merging your patches.

Ya, that sounds good to me, thanks!

> 
> --
> paul-moore.com