linux-kernel - Re: [PATCH v4 1/5] arm64: errata: Add QCOM_KRYO_4XX_GOLD to the spectre_bhb_k24

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7cfdab48-a044-46f7-8700-46e3595d8690@quicinc.com>
Date: Fri, 7 Feb 2025 14:56:50 -0800
From: Trilok Soni <quic_tsoni@...cinc.com>
To: Douglas Anderson <dianders@...omium.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Mark Rutland
	<mark.rutland@....com>
CC: Roxana Bradescu <roxabee@...gle.com>,
        Julius Werner
	<jwerner@...omium.org>,
        <bjorn.andersson@....qualcomm.com>, <linux-arm-msm@...r.kernel.org>,
        Florian Fainelli
	<florian.fainelli@...adcom.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        Jeffrey Hugo <quic_jhugo@...cinc.com>,
        Scott Bauer <sbauer@...cinc.com>, <stable@...r.kernel.org>,
        James Morse <james.morse@....com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 1/5] arm64: errata: Add QCOM_KRYO_4XX_GOLD to the
 spectre_bhb_k24_list

On 1/7/2025 12:05 PM, Douglas Anderson wrote:
> Qualcomm Kryo 400-series Gold cores have a derivative of an ARM Cortex
> A76 in them. Since A76 needs Spectre mitigation via looping then the
> Kyro 400-series Gold cores also need Spectre mitigation via looping.
> 
> Qualcomm has confirmed that the proper "k" value for Kryo 400-series
> Gold cores is 24.
> 
> Fixes: 558c303c9734 ("arm64: Mitigate spectre style branch history side channels")
> Cc: stable@...r.kernel.org
> Cc: Scott Bauer <sbauer@...cinc.com>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> 
> Changes in v4:
> - Re-added QCOM_KRYO_4XX_GOLD k24 patch after Qualcomm confirmed.
> 
> Changes in v3:
> - Removed QCOM_KRYO_4XX_GOLD k24 patch.
> 
> Changes in v2:
> - Slight change to wording and notes of KRYO_4XX_GOLD patch
> 
>  arch/arm64/kernel/proton-pack.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/proton-pack.c b/arch/arm64/kernel/proton-pack.c
> index da53722f95d4..e149efadff20 100644
> --- a/arch/arm64/kernel/proton-pack.c
> +++ b/arch/arm64/kernel/proton-pack.c
> @@ -866,6 +866,7 @@ u8 spectre_bhb_loop_affected(int scope)
>  			MIDR_ALL_VERSIONS(MIDR_CORTEX_A76),
>  			MIDR_ALL_VERSIONS(MIDR_CORTEX_A77),
>  			MIDR_ALL_VERSIONS(MIDR_NEOVERSE_N1),
> +			MIDR_ALL_VERSIONS(MIDR_QCOM_KRYO_4XX_GOLD),
>  			{},
>  		};
>  		static const struct midr_range spectre_bhb_k11_list[] = {

LGTM. Sorry for the delay. 

Acked-by: Trilok Soni <quic_tsoni@...cinc.com>

-- 
---Trilok Soni