linux-kernel - Re: [PATCH v2 09/12] dt-bindings: memory-controllers: Convert fsl,elbc to YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173897189669.2630636.11579554304003668196.robh@kernel.org>
Date: Fri, 07 Feb 2025 17:44:59 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: J. Neuschäfer <j.ne@...teo.net>
Cc: Mark Brown <broonie@...nel.org>, Damien Le Moal <dlemoal@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, linux-ide@...r.kernel.org, 
 "David S. Miller" <davem@...emloft.net>, linux-crypto@...r.kernel.org, 
 Vinod Koul <vkoul@...nel.org>, dmaengine@...r.kernel.org, 
 Herbert Xu <herbert@...dor.apana.org.au>, linuxppc-dev@...ts.ozlabs.org, 
 linux-spi@...r.kernel.org, 
 J. Neuschäfer <j.neuschaefer@....net>, 
 Guenter Roeck <linux@...ck-us.net>, Nicholas Piggin <npiggin@...il.com>, 
 Madhavan Srinivasan <maddy@...ux.ibm.com>, 
 Krzysztof Kozlowski <krzk@...nel.org>, 
 Krzysztof Wilczyński <kw@...ux.com>, 
 Bjorn Helgaas <bhelgaas@...gle.com>, Naveen N Rao <naveen@...nel.org>, 
 Vignesh Raghavendra <vigneshr@...com>, imx@...ts.linux.dev, 
 Niklas Cassel <cassel@...nel.org>, Scott Wood <oss@...error.net>, 
 Michael Ellerman <mpe@...erman.id.au>, Richard Weinberger <richard@....at>, 
 Lorenzo Pieralisi <lpieralisi@...nel.org>, Lee Jones <lee@...nel.org>, 
 linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-mtd@...ts.infradead.org, 
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, 
 Christophe Leroy <christophe.leroy@...roup.eu>, 
 Wim Van Sebroeck <wim@...ux-watchdog.org>, linux-kernel@...r.kernel.org, 
 Miquel Raynal <miquel.raynal@...tlin.com>, linux-pci@...r.kernel.org
Subject: Re: [PATCH v2 09/12] dt-bindings: memory-controllers: Convert
 fsl,elbc to YAML

On Fri, 07 Feb 2025 22:30:26 +0100, J. Neuschäfer wrote:
> Convert the Freescale localbus controller bindings from text form to
> YAML. The updated list of compatible strings reflects current usage
> in arch/powerpc/boot/dts/, except that many existing device trees
> erroneously specify "simple-bus" in addition to fsl,*elbc.
> 
> Changes compared to the txt version:
>  - removed the board-control (fsl,mpc8272ads-bcsr) node because it only
>    appears in this example and nowhere else
>  - added a new example with NAND flash
>  - updated list of compatible strings
> 
> Signed-off-by: J. Neuschäfer <j.ne@...teo.net>
> ---
> 
> V2:
> - fix order of properties in examples, according to dts coding style
> - move to Documentation/devicetree/bindings/memory-controllers
> - clarify the commit message a tiny bit
> - remove unnecessary multiline markers (|)
> - define address format in patternProperties
> - trim subject line (remove "binding")
> - remove use of "simple-bus", because it's technically incorrect
> ---
>  .../bindings/memory-controllers/fsl,elbc.yaml      | 146 +++++++++++++++++++++
>  .../devicetree/bindings/powerpc/fsl/lbc.txt        |  43 ------
>  2 files changed, 146 insertions(+), 43 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: /example-0/localbus@...10100/simple-periph@2,0: failed to match any schema with compatible: ['fsl,elbc-gpcm-uio']
Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: /example-1/localbus@...05000/nand@1,0: failed to match any schema with compatible: ['fsl,mpc8315-fcm-nand', 'fsl,elbc-fcm-nand']
Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: /example-1/localbus@...05000/nand@1,0: failed to match any schema with compatible: ['fsl,mpc8315-fcm-nand', 'fsl,elbc-fcm-nand']

doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/display/ssd1289fb.txt references a file that doesn't exist: Documentation/devicetree/bindings/powerpc/fsl/lbc.txt
Documentation/devicetree/bindings/display/ssd1289fb.txt: Documentation/devicetree/bindings/powerpc/fsl/lbc.txt

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207-ppcyaml-v2-9-8137b0c42526@posteo.net

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.