linux-kernel - Re: [PATCH RFC 03/33] locking: Introduce <linux/thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250207035345.GA4920@lst.de>
Date: Fri, 7 Feb 2025 04:53:45 +0100
From: Christoph Hellwig <hch@....de>
To: Bart Van Assche <bvanassche@....org>
Cc: Peter Zijlstra <peterz@...radead.org>, Will Deacon <will@...nel.org>,
	Christoph Hellwig <hch@....de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Marco Elver <elver@...gle.com>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Nathan Chancellor <nathan@...nel.org>, Kees Cook <kees@...nel.org>,
	Jann Horn <jannh@...gle.com>, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>, Boqun Feng <boqun.feng@...il.com>,
	Waiman Long <longman@...hat.com>
Subject: Re: [PATCH RFC 03/33] locking: Introduce <linux/thread_safety.h>

> - a struct that represents a synchronization object is annotated with the
>   CAPABILITY() attribute,
> - the operations on that synchronization object are annotated with the
>   ACQUIRE() and RELEASE() attributes,
> - if variables or members that should be guarded by a synchronization
>   object are annotated with GUARDED_BY(),

Those are all nasty shouting names, without and good prefixing.

But more importantly ACQUIRE() and RELEASE() seems to duplicate the
existing __acquires/__releases annotations from sparse.  We really need
to find away to unify them instead of duplicating the annotations.