linux-kernel - Re: [PATCH] cpufreq: Use str_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250207041654.62xollzzkehl6rjk@vireshk-i7>
Date: Fri, 7 Feb 2025 09:46:54 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Lifeng Zheng <zhenglifeng1@...wei.com>
Cc: rafael@...nel.org, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linuxarm@...wei.com,
	jonathan.cameron@...wei.com, zhanjie9@...ilicon.com,
	lihuisong@...wei.com, fanghao11@...wei.com
Subject: Re: [PATCH] cpufreq: Use str_enable_disable() helper

On 07-02-25, 11:59, Lifeng Zheng wrote:
> Commit f994c1cb6c43 ("cpufreq: Use str_enable_disable()-like helpers") has
> already introduced helpers from string_choices.h and replaced ternary
> syntax with it. Use str_enable_disable() helper in this line to stay
> consistent.
> 
> Signed-off-by: Lifeng Zheng <zhenglifeng1@...wei.com>
> ---
>  drivers/cpufreq/cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 30ffbddc7ece..a12e1da89163 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1578,7 +1578,7 @@ static int cpufreq_online(unsigned int cpu)
>  		if (ret) {
>  			/* If the set_boost fails, the online operation is not affected */
>  			pr_info("%s: CPU%d: Cannot %s BOOST\n", __func__, policy->cpu,
> -				policy->boost_enabled ? "enable" : "disable");
> +				str_enable_disable(policy->boost_enabled));
>  			policy->boost_enabled = !policy->boost_enabled;
>  		}
>  	}

Applied, thanks.

Rafael, I have picked this since I am carrying other boost related
changes via my series. Please let me know if you want to pick it up
for rc.

-- 
viresh