linux-kernel - Re: [PATCH v3 1/6] rust: docs: add missing newline to printing macro examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSn7Tiu8xdrUO-86_h7g=xDU4cU8_yEyurb1taePbE2Wkw@mail.gmail.com>
Date: Fri, 7 Feb 2025 15:37:29 +0800
From: David Gow <davidgow@...gle.com>
To: Alban Kurti <kurti@...icto.ai>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Jonathan Corbet <corbet@....net>, Dirk Behme <dirk.behme@...bosch.com>, 
	Asahi Lina <lina@...hilina.net>, Wedson Almeida Filho <wedsonaf@...il.com>, 
	Wedson Almeida Filho <walmeida@...rosoft.com>, "Andreas Hindborg (Samsung)" <nmi@...aspace.dk>, Tejun Heo <tj@...nel.org>, 
	Fiona Behrens <me@...enk.dev>, Vincenzo Palazzo <vincenzopalazzodev@...il.com>, 
	Xiangfei Ding <dingxiangfei2009@...il.com>, rust-for-linux@...r.kernel.org, 
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Martin Rodriguez Reboredo <yakoyoku@...il.com>, Fox Chen <foxhlchen@...il.com>
Subject: Re: [PATCH v3 1/6] rust: docs: add missing newline to printing macro examples

On Fri, 7 Feb 2025 at 05:08, Alban Kurti <kurti@...icto.ai> wrote:
>
> Fix adding a newline at the end of the usage of pr_info! in the
> documentation
>
> Fixes: e3c3d34507c7 ("docs: rust: Add description of Rust documentation test as KUnit ones")
> Reported-by: Miguel Ojeda <ojeda@...nel.org>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1139
> Signed-off-by: Alban Kurti <kurti@...icto.ai>
> ---

Looks fine to me as a fix for the KUnit/testing docs.

Reviewed-by: David Gow <davidgow@...gle.com>

Cheers,
-- David

>  Documentation/rust/testing.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/rust/testing.rst b/Documentation/rust/testing.rst
> index 568b71b415a4525772cb77ce76c7f9da32fac1c4..180b886e0f1ee997779f04ce85eba858e64946c0 100644
> --- a/Documentation/rust/testing.rst
> +++ b/Documentation/rust/testing.rst
> @@ -97,7 +97,7 @@ operator are also supported as usual, e.g.:
>
>         /// ```
>         /// # use kernel::{spawn_work_item, workqueue};
> -       /// spawn_work_item!(workqueue::system(), || pr_info!("x"))?;
> +       /// spawn_work_item!(workqueue::system(), || pr_info!("x\n"))?;
>         /// # Ok::<(), Error>(())
>         /// ```
>
>
> --
> 2.48.1
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5294 bytes)