linux-kernel - Re: [PATCH RFC 00/33] Compile-time thread-safety checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250207084223.GX7145@noisy.programming.kicks-ass.net>
Date: Fri, 7 Feb 2025 09:42:23 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Marco Elver <elver@...gle.com>, Will Deacon <will@...nel.org>,
	Christoph Hellwig <hch@....de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Nathan Chancellor <nathan@...nel.org>, Kees Cook <kees@...nel.org>,
	Jann Horn <jannh@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 00/33] Compile-time thread-safety checking

On Thu, Feb 06, 2025 at 10:34:09AM -0800, Bart Van Assche wrote:

> I'm looking forward to the feedback from others about what their opinion
> is about how to enable thread-safety checking in the Linux kernel.

So Bart's patches are rather SHOUTING A LOT:-(, which I find really
jarring to look at.

Also, however much I despise the sparse thing, that is something we
already have some of, so we might as well adapt that.

But I should probably go read up on the whole clang feature first. 

I've seen both have a __guarded_by() variant for structure members, can
you stack those?

Eg. perf has locking where a structure has both a raw_spinlock_t and a
mutex and modification requires holding both, but holding either is
sufficient for reading.