linux-kernel - [PATCH net-next 5/4] ptp: vmclock: Add .owner to vmclock_miscdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f5ee0186d6062eb31ed197d1b4a45c5eec110b2.camel@infradead.org>
Date: Fri, 07 Feb 2025 09:13:54 +0000
From: David Woodhouse <dwmw2@...radead.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>, 
 Richard Cochran <richardcochran@...il.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org, Mateusz Polchlopek <mateusz.polchlopek@...el.com>, 
 "Mohamed Abuelfotoh, Hazem"
	 <abuehaze@...zon.com>
Subject: [PATCH net-next 5/4] ptp: vmclock:  Add .owner to
 vmclock_miscdev_fops

From: David Woodhouse <dwmw@...zon.co.uk>

Without the .owner field, the module can be unloaded while /dev/vmclock0
is open, leading to an oops.

Fixes: 205032724226 ("ptp: Add support for the AMZNC10C 'vmclock' device")
Cc: stable@...r.kernel.org
Signed-off-by: David Woodhouse <dwmw@...zon.co.uk>
---
 drivers/ptp/ptp_vmclock.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c
index 26fcc1185ee7..b3a83b03d9c1 100644
--- a/drivers/ptp/ptp_vmclock.c
+++ b/drivers/ptp/ptp_vmclock.c
@@ -414,6 +414,7 @@ static ssize_t vmclock_miscdev_read(struct file *fp, char __user *buf,
 }
 
 static const struct file_operations vmclock_miscdev_fops = {
+	.owner = THIS_MODULE,
 	.mmap = vmclock_miscdev_mmap,
 	.read = vmclock_miscdev_read,
 };
-- 
2.48.1



Download attachment "smime.p7s" of type "application/pkcs7-signature" (5069 bytes)