| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1c0c27fb-7d4b-40ac-8483-58cbb4239f36@quicinc.com>
Date: Fri, 7 Feb 2025 14:44:09 +0530
From: Nitin Rawat <quic_nitirawa@...cinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
CC: Melody Olvera <quic_molvera@...cinc.com>, Vinod Koul <vkoul@...nel.org>,
Kishon Vijay Abraham I <kishon@...nel.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
Alim Akhtar
<alim.akhtar@...sung.com>,
Avri Altman <avri.altman@....com>,
Bart Van Assche
<bvanassche@....org>,
Bjorn Andersson <andersson@...nel.org>,
Andy Gross
<agross@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
"Satya Durga
Srinivasu Prabhala" <quic_satyap@...cinc.com>,
Trilok Soni
<quic_tsoni@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
<linux-phy@...ts.infradead.org>, <devicetree@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-scsi@...r.kernel.org>,
Manish Pandey
<quic_mapa@...cinc.com>
Subject: Re: [PATCH 2/5] phy: qcom-qmp-ufs: Add PHY Configuration support for
SM8750
On 2/5/2025 7:58 PM, Dmitry Baryshkov wrote:
> On Wed, 5 Feb 2025 at 15:57, Nitin Rawat <quic_nitirawa@...cinc.com> wrote:
>>
>>
>>
>> On 2/5/2025 5:14 PM, Dmitry Baryshkov wrote:
>>> On Wed, 5 Feb 2025 at 13:34, Nitin Rawat <quic_nitirawa@...cinc.com> wrote:
>>>>
>>>>
>>>>
>>>> On 1/14/2025 4:19 PM, Dmitry Baryshkov wrote:
>>>>> On Mon, Jan 13, 2025 at 01:46:25PM -0800, Melody Olvera wrote:
>>>>>> From: Nitin Rawat <quic_nitirawa@...cinc.com>
>>>>>>
>>>>>> Add SM8750 specific register layout and table configs. The serdes
>>>>>> TX RX register offset has changed for SM8750 and hence keep UFS
>>>>>> specific serdes offsets in a dedicated header file.
>>>>>>
>>>>>> Co-developed-by: Manish Pandey <quic_mapa@...cinc.com>
>>>>>> Signed-off-by: Manish Pandey <quic_mapa@...cinc.com>
>>>>>> Signed-off-by: Nitin Rawat <quic_nitirawa@...cinc.com>
>>>>>> Signed-off-by: Melody Olvera <quic_molvera@...cinc.com>
>>>>>> ---
>>>>>> drivers/phy/qualcomm/phy-qcom-qmp-qserdes-com-v6.h | 12 ++
>>>>>> .../qualcomm/phy-qcom-qmp-qserdes-txrx-ufs-v7.h | 68 ++++++++
>>>>>> drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 174 ++++++++++++++++++++-
>>>>>> 3 files changed, 253 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-com-v6.h b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-com-v6.h
>>>>>> index 328c6c0b0b09ae4ff5bf14e846772e6d0f31ce5a..aa2278f9377408b3c602f6fa0de5021804f21f52 100644
>>>>>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-com-v6.h
>>>>>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-com-v6.h
>>>>>> @@ -86,4 +86,16 @@
>>>>>> #define QSERDES_V6_COM_CMN_STATUS 0x1d0
>>>>>> #define QSERDES_V6_COM_C_READY_STATUS 0x1f8
>>>>>>
>>>>>> +#define QSERDES_V6_COM_ADAPTIVE_ANALOG_CONFIG 0x268
>>>>>> +#define QSERDES_V6_COM_CP_CTRL_ADAPTIVE_MODE0 0x26c
>>>>>> +#define QSERDES_V6_COM_PLL_RCCTRL_ADAPTIVE_MODE0 0x270
>>>>>> +#define QSERDES_V6_COM_PLL_CCTRL_ADAPTIVE_MODE0 0x274
>>>>>> +#define QSERDES_V6_COM_BIN_VCOCAL_CMP_CODE1_MODE0 0x58
>>>>>> +
>>>>>> +#define QSERDES_V6_COM_BIN_VCOCAL_CMP_CODE2_MODE0 0x5c
>>>>>> +#define QSERDES_V6_COM_CP_CTRL_ADAPTIVE_MODE1 0x278
>>>>>> +#define QSERDES_V6_COM_PLL_RCCTRL_ADAPTIVE_MODE1 0x27c
>>>>>> +#define QSERDES_V6_COM_PLL_CCTRL_ADAPTIVE_MODE1 0x280
>>>>>> +#define QSERDES_V6_COM_BIN_VCOCAL_CMP_CODE1_MODE1 0x50
>>>>>> +#define QSERDES_V6_COM_BIN_VCOCAL_CMP_CODE2_MODE1 0x54
>>>>>> #endif
>>>>>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-ufs-v7.h b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-ufs-v7.h
>>>>>> new file mode 100644
>>>>>> index 0000000000000000000000000000000000000000..73b3857e0277ce6cdbe658066772172a94f25d6e
>>>>>> --- /dev/null
>>>>>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-txrx-ufs-v7.h
>>>>>> @@ -0,0 +1,68 @@
>>>>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>>>>> +/*
>>>>>> + * Copyright (c) 2024, Linaro Limited
>>>>>> + */
>>>>>> +
>>>>>> +#ifndef QCOM_PHY_QMP_QSERDES_TXRX_UFS_V7_H_
>>>>>> +#define QCOM_PHY_QMP_QSERDES_TXRX_UFS_V7_H_
>>>>>> +
>>>>>> +#define QSERDES_UFS_V7_TX_RES_CODE_LANE_TX 0x28
>>>>>> +#define QSERDES_UFS_V7_TX_RES_CODE_LANE_RX 0x2c
>>>>>> +#define QSERDES_UFS_V7_TX_RES_CODE_LANE_OFFSET_TX 0x30
>>>>>> +#define QSERDES_UFS_V7_TX_RES_CODE_LANE_OFFSET_RX 0x34
>>>>>> +#define QSERDES_UFS_V7_TX_LANE_MODE_1 0x7c
>>>>>> +#define QSERDES_UFS_V7_TX_FR_DCC_CTRL 0x108
>>>>>> +
>>>>>> +#define QSERDES_UFS_V7_RX_UCDR_SO_SATURATION 0x28
>>>>>> +#define QSERDES_UFS_V7_RX_UCDR_PI_CTRL1 0x58
>>>>>> +#define QSERDES_UFS_V7_RX_TERM_BW_CTRL0 0xC4
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE_0_1_B0 0x218
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE_0_1_B1 0x21C
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE_0_1_B2 0x220
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE_0_1_B3 0x224
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE_0_1_B4 0x228
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE_0_1_B6 0x230
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE_0_1_B7 0x234
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE2_B3 0x248
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE2_B6 0x254
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE2_B7 0x258
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE3_B0 0x260
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE3_B1 0x264
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE3_B2 0x268
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE3_B3 0x26C
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE3_B4 0x270
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE3_B5 0x274
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE3_B7 0x27C
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE3_B8 0x280
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SA_B0 0x284
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SA_B1 0x288
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SA_B2 0x28C
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SA_B3 0x290
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SA_B4 0x294
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SA_B5 0x298
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SA_B6 0x29C
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SA_B7 0x2A0
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SB_B0 0x2A8
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SB_B1 0x2AC
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SB_B2 0x2B0
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SB_B3 0x2B4
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SB_B4 0x2B8
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SB_B5 0x2BC
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SB_B6 0x2C0
>>>>>> +#define QSERDES_UFS_V7_RX_MODE_RATE4_SB_B7 0x2C4
>>>>>> +#define QSERDES_UFS_V7_RX_DLL0_FTUNE_CTRL 0x348
>>>>>> +#define QSERDES_UFS_V7_RX_SIGDET_CAL_TRIM 0x380
>>>>>> +#define QSERDES_UFS_V7_RX_INTERFACE_MODE 0x1F0
>>>>>> +#define QSERDES_UFS_V7_RX_UCDR_FO_GAIN_RATE2 0xD4
>>>>>> +#define QSERDES_UFS_V7_RX_UCDR_FO_GAIN_RATE4 0xDC
>>>>>> +#define QSERDES_UFS_V7_RX_UCDR_SO_GAIN_RATE4 0xF0
>>>>>> +#define QSERDES_UFS_V7_RX_UCDR_PI_CONTROLS 0xF4
>>>>>> +#define QSERDES_UFS_V7_RX_UCDR_FASTLOCK_COUNT_HIGH_RATE4 0x54
>>>>>> +#define QSERDES_UFS_V7_RX_UCDR_FASTLOCK_FO_GAIN_RATE4 0x10
>>>>>> +#define QSERDES_UFS_V7_RX_UCDR_FASTLOCK_SO_GAIN_RATE4 0x24
>>>>>> +#define QSERDES_UFS_V7_RX_EQ_OFFSET_ADAPTOR_CNTRL1 0x1CC
>>>>>> +#define QSERDES_UFS_V7_RX_OFFSET_ADAPTOR_CNTRL3 0x1D4
>>>>>> +#define QSERDES_UFS_V7_RX_EQU_ADAPTOR_CNTRL4 0x1B4
>>>>>> +#define QSERDES_UFS_V7_RX_VGA_CAL_MAN_VAL 0x178
>>>>>
>>>>> - Lowercase hex
>>>>> - Sort RX by the register offset
>>>>
>>>> Sure Will take care in next patchset.
>>>
>>> Just to note, please sort QSERDES_V6_COM regs too.
>>>
>>>>
>>>>>
>>>>>
>>>>>> +
>>>>>> +#endif
>>>>>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>>>>>> index d964bdfe870029226482f264c78a27d0ec43bf2b..a1695b368fe7622bf8663343d0241b4d0d40ab59 100644
>>>>>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>>>>>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>>>>>> @@ -31,6 +31,7 @@
>>>>>> #include "phy-qcom-qmp-pcs-ufs-v6.h"
>>>>>>
>>>>>> #include "phy-qcom-qmp-qserdes-txrx-ufs-v6.h"
>>>>>> +#include "phy-qcom-qmp-qserdes-txrx-ufs-v7.h"
>>>>>>
>>>>>> /* QPHY_PCS_READY_STATUS bit */
>>>>>> #define PCS_READY BIT(0)
>>>>>> @@ -949,6 +950,132 @@ static const struct qmp_phy_init_tbl sm8650_ufsphy_g5_pcs[] = {
>>>>>> QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_HSG5_SYNC_WAIT_TIME, 0x9e),
>>>>>> };
>>>>>>
>>>>>> +static const struct qmp_phy_init_tbl sm8750_ufsphy_serdes[] = {
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_SYSCLK_EN_SEL, 0xD9),
>>>>>
>>>>> Lowercase hex
>>>>
>>>> Sure Will take care in next patchset.
>>>>>
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_CMN_CONFIG_1, 0x16),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_HSCLK_SEL_1, 0x11),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_HSCLK_HS_SWITCH_SEL_1, 0x00),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_LOCK_CMP_EN, 0x01),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_LOCK_CMP_CFG, 0x60),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_IVCO, 0x1F),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_IVCO_MODE1, 0x1F),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_CMN_IETRIM, 0x07),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_CMN_IPTRIM, 0x20),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_VCO_TUNE_MAP, 0x04),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_VCO_TUNE_CTRL, 0x40),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_ADAPTIVE_ANALOG_CONFIG, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_DEC_START_MODE0, 0x41),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_CP_CTRL_MODE0, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_RCTRL_MODE0, 0x18),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_CCTRL_MODE0, 0x14),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_CP_CTRL_ADAPTIVE_MODE0, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_RCCTRL_ADAPTIVE_MODE0, 0x18),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_CCTRL_ADAPTIVE_MODE0, 0x14),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_LOCK_CMP1_MODE0, 0x7F),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_LOCK_CMP2_MODE0, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_BIN_VCOCAL_CMP_CODE1_MODE0, 0x92),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_BIN_VCOCAL_CMP_CODE2_MODE0, 0x1E),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_DEC_START_MODE1, 0x4C),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_CP_CTRL_MODE1, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_RCTRL_MODE1, 0x18),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_CCTRL_MODE1, 0x14),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_CP_CTRL_ADAPTIVE_MODE1, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_RCCTRL_ADAPTIVE_MODE1, 0x18),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_PLL_CCTRL_ADAPTIVE_MODE1, 0x14),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_LOCK_CMP1_MODE1, 0x99),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_LOCK_CMP2_MODE1, 0x07),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_BIN_VCOCAL_CMP_CODE1_MODE1, 0xBE),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_V6_COM_BIN_VCOCAL_CMP_CODE2_MODE1, 0x23),
>>>>>> +};
>>>>>> +
>>>>>> +static const struct qmp_phy_init_tbl sm8750_ufsphy_tx[] = {
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_TX_LANE_MODE_1, 0x00),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_TX_RES_CODE_LANE_OFFSET_TX, 0x07),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_TX_RES_CODE_LANE_OFFSET_RX, 0x17),
>>>>>> +};
>>>>>> +
>>>>>> +static const struct qmp_phy_init_tbl sm8750_ufsphy_rx[] = {
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_UCDR_FO_GAIN_RATE2, 0x0C),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_UCDR_FO_GAIN_RATE4, 0x0C),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_UCDR_SO_GAIN_RATE4, 0x04),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_EQ_OFFSET_ADAPTOR_CNTRL1, 0x14),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_UCDR_PI_CONTROLS, 0x07),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_OFFSET_ADAPTOR_CNTRL3, 0x0E),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_UCDR_FASTLOCK_COUNT_HIGH_RATE4, 0x02),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_UCDR_FASTLOCK_FO_GAIN_RATE4, 0x1C),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_UCDR_FASTLOCK_SO_GAIN_RATE4, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_VGA_CAL_MAN_VAL, 0x8E),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_EQU_ADAPTOR_CNTRL4, 0x0F),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE_0_1_B0, 0xCE),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE_0_1_B1, 0xCE),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE_0_1_B2, 0x18),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE_0_1_B3, 0x1A),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE_0_1_B4, 0x0F),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE_0_1_B6, 0x60),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE_0_1_B7, 0x62),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE2_B3, 0x9A),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE2_B6, 0xE2),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE2_B7, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE3_B0, 0x1B),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE3_B1, 0x1B),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE3_B2, 0x98),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE3_B3, 0x9B),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE3_B4, 0x2A),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE3_B5, 0x12),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE3_B7, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE3_B8, 0x01),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SA_B0, 0x93),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SA_B1, 0x93),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SA_B2, 0x60),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SA_B3, 0x99),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SA_B4, 0x5F),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SA_B5, 0x92),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SA_B6, 0xE3),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SA_B7, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SB_B0, 0x9B),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SB_B1, 0x9B),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SB_B2, 0x60),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SB_B3, 0x99),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SB_B4, 0x5F),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SB_B5, 0x92),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SB_B6, 0xFB),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_MODE_RATE4_SB_B7, 0x06),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_UCDR_SO_SATURATION, 0x1F),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_UCDR_PI_CTRL1, 0x94),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_TERM_BW_CTRL0, 0xFA),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_DLL0_FTUNE_CTRL, 0x30),
>>>>>> + QMP_PHY_INIT_CFG(QSERDES_UFS_V7_RX_SIGDET_CAL_TRIM, 0x77),
>>>>>> +};
>>>>>> +
>>>>>> +static const struct qmp_phy_init_tbl sm8750_ufsphy_pcs[] = {
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_MULTI_LANE_CTRL1, 0x02),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_MID_TERM_CTRL1, 0x43),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_PCS_CTRL1, 0x40),
>>>>>
>>>>> Why does SM8650 have 0xc1 here?
>>>>
>>>> SM8750 phy is different from SM8650 and hence it is using different phy
>>>> calibration setting. This value is as per Hardware programming guide.'
>>>
>>> Ack.
>>>
>>>>
>>>>>
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_LARGE_AMP_DRV_LVL, 0x0F),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_SIGDET_CTRL2, 0x68),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_POST_EMP_LVL_S4, 0x0E),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_POST_EMP_LVL_S5, 0x12),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_POST_EMP_LVL_S6, 0x15),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_POST_EMP_LVL_S7, 0x19),
>>>>>> +};
>>>>>> +
>>>>>> +static const struct qmp_phy_init_tbl sm8750_ufsphy_g4_pcs[] = {
>>>>>
>>>>> Missing QPHY_V6_PCS_UFS_PLL_CNTL, then it becomes sm8650_ufsphy_g4_pcs
>>>>
>>>> The value of QPHY_V6_PCS_UFS_PLL_CNTL is 0x33 for SM8750 as it is
>>>> operating on 80bit mode. Similiar change needs to be done for SM8650.
>>>
>>> Ack, please check if that allows the driver to use the same set of
>>> tables for SM8650 and SM8750.
>>>
>>>>>
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_HSGEAR_CAPABILITY, 0x04),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_HSGEAR_CAPABILITY, 0x04),
>>>>>> +};
>>>>>> +
>>>>>> +static const struct qmp_phy_init_tbl sm8750_ufsphy_g5_pcs[] = {
>>>>>
>>>>> sm8650_ufsphy_g5_pcs?
>>>> Agree with you. Good Finding. I will replace sm8750_ufsphy_g5_pcs with
>>>> sm8650_ufsphy_g5_pcs.
>>>>
>>>>
>>>>>
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_PLL_CNTL, 0x33),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_HSGEAR_CAPABILITY, 0x05),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_HSGEAR_CAPABILITY, 0x05),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_HS_G5_SYNC_LENGTH_CAPABILITY, 0x4d),
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_HSG5_SYNC_WAIT_TIME, 0x9e),
>>>>>> +};
>>>>>> +
>>>>>> +static const struct qmp_phy_init_tbl sm8750_ufsphy_hs_b_pcs[] = {
>>>>>> + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_PCS_CTRL1, 0x41),
>>>>>> +};
>>>>>> +
>>>>>> struct qmp_ufs_offsets {
>>>>>> u16 serdes;
>>>>>> u16 pcs;
>>>>>> @@ -1523,6 +1650,45 @@ static const struct qmp_phy_cfg sm8650_ufsphy_cfg = {
>>>>>> .regs = ufsphy_v6_regs_layout,
>>>>>> };
>>>>>>
>>>>>> +static const struct qmp_phy_cfg sm8750_ufsphy_cfg = {
>>>>>> + .lanes = 2,
>>>>>> +
>>>>>> + .offsets = &qmp_ufs_offsets_v6,
>>>>>> + .max_supported_gear = UFS_HS_G5,
>>>>>> +
>>>>>> + .tbls = {
>>>>>> + .serdes = sm8750_ufsphy_serdes,
>>>>>> + .serdes_num = ARRAY_SIZE(sm8750_ufsphy_serdes),
>>>>>> + .tx = sm8750_ufsphy_tx,
>>>>>> + .tx_num = ARRAY_SIZE(sm8750_ufsphy_tx),
>>>>>> + .rx = sm8750_ufsphy_rx,
>>>>>> + .rx_num = ARRAY_SIZE(sm8750_ufsphy_rx),
>>>>>> + .pcs = sm8750_ufsphy_pcs,
>>>>>> + .pcs_num = ARRAY_SIZE(sm8750_ufsphy_pcs),
>>>>>> + },
>>>>>> +
>>>>>> + .tbls_hs_b = {
>>>>>> + .pcs = sm8750_ufsphy_hs_b_pcs,
>>>>>> + .pcs_num = ARRAY_SIZE(sm8750_ufsphy_hs_b_pcs),
>>>>>> + },
>>>>>> +
>>>>>> + .tbls_hs_overlay[0] = {
>>>>>> + .pcs = sm8750_ufsphy_g4_pcs,
>>>>>> + .pcs_num = ARRAY_SIZE(sm8750_ufsphy_g4_pcs),
>>>>>> + .max_gear = UFS_HS_G4,
>>>>>> + },
>>>>>> + .tbls_hs_overlay[1] = {
>>>>>> + .pcs = sm8750_ufsphy_g5_pcs,
>>>>>> + .pcs_num = ARRAY_SIZE(sm8750_ufsphy_g5_pcs),
>>>>>> + .max_gear = UFS_HS_G5,
>>>>>> + },
>>>>>> +
>>>>>> + .vreg_list = qmp_phy_vreg_l,
>>>>>> + .num_vregs = ARRAY_SIZE(qmp_phy_vreg_l),
>>>>>> + .regs = ufsphy_v6_regs_layout,
>>>>>> +
>>>>>> +};
>>>>>> +
>>>>>> static void qmp_ufs_serdes_init(struct qmp_ufs *qmp, const struct qmp_phy_cfg_tbls *tbls)
>>>>>> {
>>>>>> void __iomem *serdes = qmp->serdes;
>>>>>> @@ -1593,8 +1759,10 @@ static void qmp_ufs_init_registers(struct qmp_ufs *qmp, const struct qmp_phy_cfg
>>>>>> qmp_ufs_pcs_init(qmp, &cfg->tbls_hs_overlay[i]);
>>>>>> }
>>>>>>
>>>>>> - if (qmp->mode == PHY_MODE_UFS_HS_B)
>>>>>> + if (qmp->mode == PHY_MODE_UFS_HS_B) {
>>>>>> qmp_ufs_serdes_init(qmp, &cfg->tbls_hs_b);
>>>>>> + qmp_ufs_pcs_init(qmp, &cfg->tbls_hs_b);
>>>>>
>>>>> Extract the serdes+lanes+pcs helper, use it in this function.
>>>>
>>>> Lane init is already a different helper and is already being called from
>>>> function (qmp_ufs_init_register). Here we just adding few extra PCS
>>>> registers needed to support Rate B.
>>>
>>> Please extract the helper that calls qmp_ufs_serdes_init() +
>>> qmp_ufs_lanes_init() + qmp_ufs_pcs_init() over a particular table.
>>
>> Hi Dmitry,
>>
>> Do you mean to move qmp_ufs_serdes_init , qmp_ufs_lanes_init and
>> qmp_ufs_pcs_init into a different wrapper function and call this wrapper
>> from qmp_ufs_init_registers for each table.
>
> Yes.
>
>>
>> But for tbls_hs_b, we just need qmp_ufs_serdes_init and
>> qmp_ufs_pcs_init. qmp_ufs_lanes_init is not required for tbls_hs_b.
>> So wrapper API won't be of much help.
>
> It still is, it removes a need to care about the particular table.
> Historically tbls_hs_b had only qserdes. Now you've added pcs. I don't
> think we should wait for somebody to add tx/rx on top of that.
Sure. I'll take care of this as well in next patchset. Thanks.
>
>>
>> Regards,
>> Nitin
>>
>>
>>>
>>>>
>>>>>
>>>>>> + }
>>>>>> }
>>>>>>
>>>>>> static int qmp_ufs_com_init(struct qmp_ufs *qmp)
>>>>>> @@ -2061,7 +2229,11 @@ static const struct of_device_id qmp_ufs_of_match_table[] = {
>>>>>> }, {
>>>>>> .compatible = "qcom,sm8650-qmp-ufs-phy",
>>>>>> .data = &sm8650_ufsphy_cfg,
>>>>>> + }, {
>>>>>> + .compatible = "qcom,sm8750-qmp-ufs-phy",
>>>>>> + .data = &sm8750_ufsphy_cfg,
>>>>>> },
>>>>>> +
>>>>>> { },
>>>>>> };
>>>>>> MODULE_DEVICE_TABLE(of, qmp_ufs_of_match_table);
>>>>>>
>>>>>> --
>>>>>> 2.46.1
>>>>>>
>>>>>
>>>> Thanks,
>>>> Nitin
>>>>
>>>
>>>
>>
>
>
Powered by blists - more mailing lists