linux-kernel - [PATCH] driver: block: release the lo_work_lock before queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250207091942.3966756-1-zhaoyang.huang@unisoc.com>
Date: Fri, 7 Feb 2025 17:19:42 +0800
From: "zhaoyang.huang" <zhaoyang.huang@...soc.com>
To: Jens Axboe <axboe@...nel.dk>, Dan Schatzberg <schatzberg.dan@...il.com>,
        <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Zhaoyang Huang
	<huangzhaoyang@...il.com>, <steve.kang@...soc.com>
Subject: [PATCH] driver: block: release the lo_work_lock before queue_work

From: Zhaoyang Huang <zhaoyang.huang@...soc.com>

queue_work could spin on wq->cpu_pwq->pool->lock which could lead to
concurrent loop_process_work failed on lo_work_lock contention and
increase the request latency. Remove this combination by moving the
lock release ahead of queue_work.

Signed-off-by: Zhaoyang Huang <zhaoyang.huang@...soc.com>
---
 drivers/block/loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 8f6761c27c68..33e31cd95953 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -890,8 +890,8 @@ static void loop_queue_work(struct loop_device *lo, struct loop_cmd *cmd)
 		cmd_list = &lo->rootcg_cmd_list;
 	}
 	list_add_tail(&cmd->list_entry, cmd_list);
-	queue_work(lo->workqueue, work);
 	spin_unlock_irq(&lo->lo_work_lock);
+	queue_work(lo->workqueue, work);
 }
 
 static void loop_set_timer(struct loop_device *lo)
-- 
2.25.1