linux-kernel - Re: [PATCH v2 00/45] Consolidate hrtimer initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ikpmypts.fsf@ubik.fi.intel.com>
Date: Fri, 07 Feb 2025 13:08:47 +0200
From: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
To: Thomas Gleixner <tglx@...utronix.de>, Nam Cao <namcao@...utronix.de>,
 Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker
 <frederic@...nel.org>, linux-kernel@...r.kernel.org
Cc: Nam Cao <namcao@...utronix.de>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, "Martin K. Petersen"
 <martin.petersen@...cle.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Sebastian Reichel
 <sre@...nel.org>, Will Deacon <will@...nel.org>, Jon Mason
 <jdmason@...zu.us>, Jaehoon Chung <jh80.chung@...sung.com>, Hans Verkuil
 <hverkuil-cisco@...all.nl>, Jassi Brar <jassisinghbrar@...il.com>, Pavel
 Machek <pavel@....cz>, Dmitry Torokhov <dmitry.torokhov@...il.com>,
 Jonathan Cameron <jic23@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
 Alex Deucher <alexander.deucher@....com>, Jani Nikula
 <jani.nikula@...ux.intel.com>, Rob Clark <robdclark@...il.com>, Lucas De
 Marchi <lucas.demarchi@...el.com>, Zack Rusin <zack.rusin@...adcom.com>,
 "Michael S. Tsirkin" <mst@...hat.com>, Jason Gunthorpe <jgg@...pe.ca>, Uwe
 Kleine-König <ukleinek@...nel.org>, Takashi Iwai
 <tiwai@...e.com>,
 alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH v2 00/45] Consolidate hrtimer initialization - Part 4

Thomas Gleixner <tglx@...utronix.de> writes:

> On Thu, Feb 06 2025 at 11:56, Alexander Shishkin wrote:
>> Nam Cao <namcao@...utronix.de> writes:
>>
>>> hrtimers is initialized with hrtimer_init(), and after that the timer's
>>> callback function is setup separately. This separate initialization is
>>> error prone and awkward to use.
>>>
>>> hrtimer_setup() combines the initialization and is simpler to use.
>>>
>>> Switch to use the new setup function. Most conversions were done with
>>> Coccinelle, see the sematic patch below.
>>>
>>> This series is intended to be applied to the tip tree
>>>
>>> v1 -> v2 https://lore.kernel.org/lkml/cover.1729865485.git.namcao@linutronix.de
>>>   - rebase onto v6.14-rc1
>>
>> Link to v2 of part 1 is missing. It's also somehow not in my notmuch
>> datadase (looked for "hrtimers: Switch to new hrtimer interface
>> functions" -- took a guess based on v1) and is not googleable. It's kind
>> of important for reviewing this one. v1 did have the links to the other
>> parts, at least.
>
> It's archived and searchable on lore:
>
>   https://lore.kernel.org/all/?q=hrtimers%3A+Consolidate+hrtimer+initialization+-+Part+1
>
> and the third google result points to:
>
> https://patchwork.kernel.org/project/linux-wireless/patch/20241031-hrtimer_setup_p1_v2-v2-0-23400656575a@linutronix.de/

In the only other version that I was CC'd on, Part 1's subject line was:
"hrtimers: Switch to new hrtimer interface functions", hence the
confusion.

> That part 1 series has been applied and is in mainline already.

Yes, I was grepping for the function that got removed. Low caffeine
level in the bloodstream or something.

But now that it's in mainline, I can pick up the patch intended for me
or just ack it. Any preferences?

Thanks,
--
Alex