linux-kernel - Re: [PATCH v1] arm64: dts: ti: k3-am62p: Enable AUDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250207014239.xzm6rfnusckql2uo@litigator>
Date: Thu, 6 Feb 2025 19:42:39 -0600
From: Nishanth Menon <nm@...com>
To: Francesco Dolcini <francesco@...cini.it>
CC: Vignesh Raghavendra <vigneshr@...com>, Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Francesco Dolcini
	<francesco.dolcini@...adex.com>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] arm64: dts: ti: k3-am62p: Enable AUDIO_REFCLKx

On 16:39-20250206, Francesco Dolcini wrote:
> From: Francesco Dolcini <francesco.dolcini@...adex.com>
> 
> On AM62P-based SoCs the AUDIO_REFCLKx clocks can be used as an input to
> external peripherals when configured through CTRL_MMR, so add the
> clock nodes.
> 
> Link: http://downloads.ti.com/tisci/esd/latest/5_soc_doc/am62px/clocks.html
> Signed-off-by: Francesco Dolcini <francesco.dolcini@...adex.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> index 420c77c8e9e5..4b47b0774330 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
> @@ -42,6 +42,26 @@ &inta_main_dmss {
>  	ti,interrupt-ranges = <5 69 35>;
>  };
>  
> +&main_conf {

	Why not add it to main_conf section it self in the file?

> +	audio_refclk0: clock-controller@...0 {
> +		compatible = "ti,am62-audio-refclk";
> +		reg = <0x82e0 0x4>;
> +		clocks = <&k3_clks 157 0>;
> +		assigned-clocks = <&k3_clks 157 0>;
> +		assigned-clock-parents = <&k3_clks 157 16>;
> +		#clock-cells = <0>;
> +	};
> +
> +	audio_refclk1: clock-controller@...4 {
> +		compatible = "ti,am62-audio-refclk";
> +		reg = <0x82e4 0x4>;
> +		clocks = <&k3_clks 157 18>;
> +		assigned-clocks = <&k3_clks 157 18>;
> +		assigned-clock-parents = <&k3_clks 157 34>;
> +		#clock-cells = <0>;
> +	};
> +};
> +
>  &main_pmx0 {
>  	pinctrl-single,gpio-range =
>  		<&main_pmx0_range 0 32 PIN_GPIO_RANGE_IOPAD>,
> -- 
> 2.39.5
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D