linux-kernel - Re: [PATCH] HID: intel-thc-hid: Remove deprecated PCI API calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <96151032-84p2-17q9-3997-sn60r0n13sp9@xreary.bet>
Date: Fri, 7 Feb 2025 13:49:10 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Philipp Stanner <phasta@...nel.org>
cc: Even Xu <even.xu@...el.com>, Xinpeng Sun <xinpeng.sun@...el.com>, 
    Benjamin Tissoires <bentiss@...nel.org>, 
    Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, 
    Mark Pearson <mpearson-lenovo@...ebb.ca>, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH] HID: intel-thc-hid: Remove deprecated PCI API calls

On Tue, 28 Jan 2025, Philipp Stanner wrote:

> intel-thc-hid reintroduced the already deprecated PCI API functions
> 
> 	pcim_iomap_table(),
> 	pcim_iomap_regions(),
> 	pcim_iounmap_regions(),
> 
> none of which should be used anymore.
> 
> Furthermore, calling managed (pcim_*) functions in remove() and probe()
> for cleanup is not necessary, since the managed functions clean up
> automatically.
> 
> Replace / remove the deprecated functions.
> 
> Fixes: 61bb2714dc3a1 ("HID: intel-thc-hid: intel-quicki2c: Add THC QuickI2C driver skeleton")
> Signed-off-by: Philipp Stanner <phasta@...nel.org>
> ---
> Hi,
> 
> I'm trying to remove this API since a year. Please pay attention to the
> docstrings in PCI which mark certain functions as deprecated.

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs