linux-kernel - Re: [PATCH net-next v4 2/3] netdev-genl: Add an XSK attribute to queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250207133055.GU554665@kernel.org>
Date: Fri, 7 Feb 2025 13:30:55 +0000
From: Simon Horman <horms@...nel.org>
To: Joe Damato <jdamato@...tly.com>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, edumazet@...gle.com,
	sridhar.samudrala@...el.com, Jakub Kicinski <kuba@...nel.org>,
	Donald Hunter <donald.hunter@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Mina Almasry <almasrymina@...gle.com>,
	Daniel Jurgens <danielj@...dia.com>,
	Amritha Nambiar <amritha.nambiar@...el.com>,
	David Wei <dw@...idwei.uk>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] netdev-genl: Add an XSK attribute to
 queues

On Fri, Feb 07, 2025 at 03:08:54AM +0000, Joe Damato wrote:
> Expose a new per-queue nest attribute, xsk, which will be present for
> queues that are being used for AF_XDP. If the queue is not being used for
> AF_XDP, the nest will not be present.
> 
> In the future, this attribute can be extended to include more data about
> XSK as it is needed.
> 
> Signed-off-by: Joe Damato <jdamato@...tly.com>
> Suggested-by: Jakub Kicinski <kuba@...nel.org>

...

> diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
> index 0dcd4faefd8d..75ca111aa591 100644
> --- a/net/core/netdev-genl.c
> +++ b/net/core/netdev-genl.c
> @@ -380,6 +380,7 @@ netdev_nl_queue_fill_one(struct sk_buff *rsp, struct net_device *netdev,
>  	struct netdev_rx_queue *rxq;
>  	struct netdev_queue *txq;
>  	void *hdr;
> +	int ret;
>  

Hi Joe,

Perhaps this got left behind after some revisions elsewhere.
But as it stands ret is unused in this function and should be removed.

>  	hdr = genlmsg_iput(rsp, info);
>  	if (!hdr)

...

-- 
pw-bot: changes-requested