linux-kernel - Re: [PATCH] fuse: removed unused function fuse_uring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56318e97-c849-4c2c-b35f-bc015a611a81@ddn.com>
Date: Fri, 7 Feb 2025 14:42:47 +0100
From: Bernd Schubert <bschubert@....com>
To: Luis Henriques <luis@...lia.com>, Miklos Szeredi <miklos@...redi.hu>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fuse: removed unused function fuse_uring_create() from
 header



On 2/7/25 14:35, Luis Henriques wrote:
> Function fuse_uring_create() is used only from dev_uring.c and does not
> need to be exposed in the header file.  Furthermore, it has the wrong
> signature.
> 
> While there, also remove the 'struct fuse_ring' forward declaration.
> 
> Signed-off-by: Luis Henriques <luis@...lia.com>
> ---
>  fs/fuse/dev_uring_i.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/fuse/dev_uring_i.h b/fs/fuse/dev_uring_i.h
> index 2102b3d0c1ae..0d67738850c5 100644
> --- a/fs/fuse/dev_uring_i.h
> +++ b/fs/fuse/dev_uring_i.h
> @@ -172,12 +172,6 @@ static inline bool fuse_uring_ready(struct fuse_conn *fc)
>  
>  #else /* CONFIG_FUSE_IO_URING */
>  
> -struct fuse_ring;
> -
> -static inline void fuse_uring_create(struct fuse_conn *fc)
> -{
> -}
> -
>  static inline void fuse_uring_destruct(struct fuse_conn *fc)
>  {
>  }


Ah yes, that is left over from earlier patch sets that were
still using ioctls.

Reviewed-by: Bernd Schubert <bschubert@....com>