linux-kernel - Re: [PATCH net-next v4 2/3] netdev-genl: Add an XSK attribute to queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202502081141.R4zMr9v1-lkp@intel.com>
Date: Sat, 8 Feb 2025 12:02:01 +0800
From: kernel test robot <lkp@...el.com>
To: Joe Damato <jdamato@...tly.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, pabeni@...hat.com, edumazet@...gle.com,
	sridhar.samudrala@...el.com, Joe Damato <jdamato@...tly.com>,
	Jakub Kicinski <kuba@...nel.org>,
	Donald Hunter <donald.hunter@...il.com>,
	Simon Horman <horms@...nel.org>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Stanislav Fomichev <sdf@...ichev.me>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Mina Almasry <almasrymina@...gle.com>,
	Daniel Jurgens <danielj@...dia.com>,
	Amritha Nambiar <amritha.nambiar@...el.com>,
	David Wei <dw@...idwei.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v4 2/3] netdev-genl: Add an XSK attribute to
 queues

Hi Joe,

kernel test robot noticed the following build warnings:

[auto build test WARNING on f3eba8edd885db439f4bfaa2cf9d766bad1ae6c5]

url:    https://github.com/intel-lab-lkp/linux/commits/Joe-Damato/netlink-Add-nla_put_empty_nest-helper/20250207-111126
base:   f3eba8edd885db439f4bfaa2cf9d766bad1ae6c5
patch link:    https://lore.kernel.org/r/20250207030916.32751-3-jdamato%40fastly.com
patch subject: [PATCH net-next v4 2/3] netdev-genl: Add an XSK attribute to queues
config: i386-buildonly-randconfig-001-20250208 (https://download.01.org/0day-ci/archive/20250208/202502081141.R4zMr9v1-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250208/202502081141.R4zMr9v1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502081141.R4zMr9v1-lkp@intel.com/

All warnings (new ones prefixed by >>):

   net/core/netdev-genl.c: In function 'netdev_nl_queue_fill_one':
>> net/core/netdev-genl.c:383:13: warning: unused variable 'ret' [-Wunused-variable]
     383 |         int ret;
         |             ^~~


vim +/ret +383 net/core/netdev-genl.c

   374	
   375	static int
   376	netdev_nl_queue_fill_one(struct sk_buff *rsp, struct net_device *netdev,
   377				 u32 q_idx, u32 q_type, const struct genl_info *info)
   378	{
   379		struct pp_memory_provider_params *params;
   380		struct netdev_rx_queue *rxq;
   381		struct netdev_queue *txq;
   382		void *hdr;
 > 383		int ret;
   384	
   385		hdr = genlmsg_iput(rsp, info);
   386		if (!hdr)
   387			return -EMSGSIZE;
   388	
   389		if (nla_put_u32(rsp, NETDEV_A_QUEUE_ID, q_idx) ||
   390		    nla_put_u32(rsp, NETDEV_A_QUEUE_TYPE, q_type) ||
   391		    nla_put_u32(rsp, NETDEV_A_QUEUE_IFINDEX, netdev->ifindex))
   392			goto nla_put_failure;
   393	
   394		switch (q_type) {
   395		case NETDEV_QUEUE_TYPE_RX:
   396			rxq = __netif_get_rx_queue(netdev, q_idx);
   397			if (nla_put_napi_id(rsp, rxq->napi))
   398				goto nla_put_failure;
   399	
   400			params = &rxq->mp_params;
   401			if (params->mp_ops &&
   402			    params->mp_ops->nl_fill(params->mp_priv, rsp, rxq))
   403				goto nla_put_failure;
   404	
   405			if (rxq->pool)
   406				if (nla_put_empty_nest(rsp, NETDEV_A_QUEUE_XSK))
   407					goto nla_put_failure;
   408	
   409			break;
   410		case NETDEV_QUEUE_TYPE_TX:
   411			txq = netdev_get_tx_queue(netdev, q_idx);
   412			if (nla_put_napi_id(rsp, txq->napi))
   413				goto nla_put_failure;
   414	
   415			if (txq->pool)
   416				if (nla_put_empty_nest(rsp, NETDEV_A_QUEUE_XSK))
   417					goto nla_put_failure;
   418	
   419			break;
   420		}
   421	
   422		genlmsg_end(rsp, hdr);
   423	
   424		return 0;
   425	
   426	nla_put_failure:
   427		genlmsg_cancel(rsp, hdr);
   428		return -EMSGSIZE;
   429	}
   430	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki