linux-kernel - Re: [PATCH V2 2/2] sched: Reduce the default slice to avoid tasks getting an extra tick

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502081304.ujyIUca2-lkp@intel.com>
Date: Sat, 8 Feb 2025 13:59:24 +0800
From: kernel test robot <lkp@...el.com>
To: zihan zhou <15645113830zzh@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, bsegall@...gle.com,
	dietmar.eggemann@....com, juri.lelli@...hat.com,
	linux-kernel@...r.kernel.org, mgorman@...e.de, mingo@...hat.com,
	peterz@...radead.org, rostedt@...dmis.org,
	vincent.guittot@...aro.org, vschneid@...hat.com
Subject: Re: [PATCH V2 2/2] sched: Reduce the default slice to avoid tasks
 getting an extra tick

Hi zihan,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on peterz-queue/sched/core linus/master v6.14-rc1 next-20250207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/zihan-zhou/sched-Reduce-the-default-slice-to-avoid-tasks-getting-an-extra-tick/20250207-142556
base:   tip/sched/core
patch link:    https://lore.kernel.org/r/20250207062402.33725-1-15645113830zzh%40gmail.com
patch subject: [PATCH V2 2/2] sched: Reduce the default slice to avoid tasks getting an extra tick
config: x86_64-randconfig-072-20250208 (https://download.01.org/0day-ci/archive/20250208/202502081304.ujyIUca2-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250208/202502081304.ujyIUca2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502081304.ujyIUca2-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from kernel/sched/build_utility.c:72:
   kernel/sched/debug.c: In function 'sched_base_slice_write':
>> kernel/sched/debug.c:193:9: error: implicit declaration of function 'sched_update_scaling'; did you mean 'sched_update_numa'? [-Werror=implicit-function-declaration]
     193 |         sched_update_scaling();
         |         ^~~~~~~~~~~~~~~~~~~~
         |         sched_update_numa
   cc1: some warnings being treated as errors


vim +193 kernel/sched/debug.c

   168	
   169	
   170	static ssize_t sched_base_slice_write(struct file *filp, const char __user *ubuf,
   171					   size_t cnt, loff_t *ppos)
   172	{
   173		char buf[16];
   174		unsigned int base_slice;
   175	
   176		if (cnt > 15)
   177			cnt = 15;
   178	
   179		if (copy_from_user(&buf, ubuf, cnt))
   180			return -EFAULT;
   181		buf[cnt] = '\0';
   182	
   183		if (kstrtouint(buf, 10, &base_slice))
   184			return -EINVAL;
   185	
   186	
   187		base_slice = clamp_t(u64, base_slice,
   188						NSEC_PER_MSEC/10,   /* HZ=1000 * 10 */
   189						NSEC_PER_MSEC*100); /* HZ=100  / 10 */
   190	
   191		sysctl_sched_base_slice = base_slice;
   192	
 > 193		sched_update_scaling();
   194	
   195		*ppos += cnt;
   196		return cnt;
   197	}
   198	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki