linux-kernel - Re: [PATCH 1/2] lib/math: Hook up tests/Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSkkmP8W0HeK7ZzikXABmM5_NNeZ9_95V8pfGRjUuW2UUA@mail.gmail.com>
Date: Sat, 8 Feb 2025 16:10:03 +0800
From: David Gow <davidgow@...gle.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: Shuah Khan <skhan@...uxfoundation.org>, 
	Luis Felipe Hernandez <luis.hernandez093@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, 
	Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 1/2] lib/math: Hook up tests/Makefile

On Sat, 8 Feb 2025 at 06:33, Tamir Duberstein <tamird@...il.com> wrote:
>
> This Makefile has been dead code since it was added in commit
> 7fcc9b53216c ("lib/math: Add int_pow test suite"); the tests worked
> because of the duplicated rules in the parent directory's Makefile. Wire
> up tests/Makefile and remove the duplication.
>
> Fixes: 7fcc9b53216c ("lib/math: Add int_pow test suite")
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---

Thanks for fixing this.

Reviewed-by: David Gow <davidgow@...gle.com>

-- David

>  lib/math/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/math/Makefile b/lib/math/Makefile
> index 853f023ae537..d390da9a59fe 100644
> --- a/lib/math/Makefile
> +++ b/lib/math/Makefile
> @@ -5,8 +5,8 @@ obj-$(CONFIG_CORDIC)            += cordic.o
>  obj-$(CONFIG_PRIME_NUMBERS)    += prime_numbers.o
>  obj-$(CONFIG_RATIONAL)         += rational.o
>
> -obj-$(CONFIG_INT_POW_TEST)  += tests/int_pow_kunit.o
>  obj-$(CONFIG_TEST_DIV64)       += test_div64.o
>  obj-$(CONFIG_TEST_MULDIV64)    += test_mul_u64_u64_div_u64.o
>  obj-$(CONFIG_RATIONAL_KUNIT_TEST) += rational-test.o
> -obj-$(CONFIG_INT_SQRT_KUNIT_TEST) += tests/int_sqrt_kunit.o
> \ No newline at end of file
> +
> +obj-y += tests/
>
> --
> 2.48.1
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5294 bytes)