linux-kernel - Re: [PATCH v2 1/6] mips/crc32: remove unused enums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXGJ9AMj88mprWkfiYk=qBtAmVG9wjz0Kh__38WoBDeXfA@mail.gmail.com>
Date: Sat, 8 Feb 2025 10:42:08 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, 
	Nathan Chancellor <nathan@...nel.org>
Subject: Re: [PATCH v2 1/6] mips/crc32: remove unused enums

On Sat, 8 Feb 2025 at 03:49, Eric Biggers <ebiggers@...nel.org> wrote:
>
> From: Eric Biggers <ebiggers@...gle.com>
>
> Remove enum crc_op_size and enum crc_type, since they are never actually
> used.  Tokens with the names of the enum values do appear in the file,
> but they are only used for token concatenation with the preprocessor.
>
> This prevents a conflict with the addition of crc32c() to linux/crc32.h.
>
> Reported-by: Nathan Chancellor <nathan@...nel.org>
> Closes: https://lore.kernel.org/r/20250207224233.GA1261167@ax162
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>  arch/mips/lib/crc32-mips.c | 9 ---------
>  1 file changed, 9 deletions(-)
>

Acked-by: Ard Biesheuvel <ardb@...nel.org>

> diff --git a/arch/mips/lib/crc32-mips.c b/arch/mips/lib/crc32-mips.c
> index 083e5d693a169..100ac586aadb2 100644
> --- a/arch/mips/lib/crc32-mips.c
> +++ b/arch/mips/lib/crc32-mips.c
> @@ -14,19 +14,10 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <asm/mipsregs.h>
>  #include <linux/unaligned.h>
>
> -enum crc_op_size {
> -       b, h, w, d,
> -};
> -
> -enum crc_type {
> -       crc32,
> -       crc32c,
> -};
> -
>  #ifndef TOOLCHAIN_SUPPORTS_CRC
>  #define _ASM_SET_CRC(OP, SZ, TYPE)                                       \
>  _ASM_MACRO_3R(OP, rt, rs, rt2,                                           \
>         ".ifnc  \\rt, \\rt2\n\t"                                          \
>         ".error \"invalid operands \\\"" #OP " \\rt,\\rs,\\rt2\\\"\"\n\t" \
> --
> 2.48.1
>