linux-kernel - Re: [PATCH v5 3/5] arm64: dts: qcom: ipq6018: move mp5496 regulator out of soc dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <x353yhiu4zsdyu5dpgfe6li53bq6b25rd3rhsquab7g4cbzehl@klbvqidc2sac>
Date: Sat, 8 Feb 2025 14:17:12 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Chukun Pan <amadeus@....edu.cn>
Cc: andersson@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org, 
	konradybcio@...nel.org, krzk+dt@...nel.org, linux-arm-msm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/5] arm64: dts: qcom: ipq6018: move mp5496 regulator
 out of soc dtsi

On Sat, Feb 08, 2025 at 04:00:15PM +0800, Chukun Pan wrote:
> Hi,
> > Wouldn't it be better to move it to the board file without having
> > intermediate include files?
> 
> The intermediate include files were suggested by you:
> https://lore.kernel.org/lkml/xmvtbib3q72tnfpcaic3vbgwilpo7yjnqimr5uk2myjgtslbgm@mlp2kqvljayc/
> 
> Unlike mobile phones or development boards, the pmic (voltage) setting
> on routers is relatively fixed. (Because QCA will not provide relevant
> documents). On IPQ60xx SoCs, s2 supplies to cpu, l2 supplies to emmc.
> The downstream vendor kernel puts it in soc.dtsi (no device override),
> so I think the include files is more appropriate.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

-- 
With best wishes
Dmitry