linux-kernel - Re: [PATCH] iio: magnetometer: si7210: fix magnetic field measurement scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250208130600.4bf562d7@jic23-huawei>
Date: Sat, 8 Feb 2025 13:06:00 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Antoni Pokusinski <apokusinski01@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, lars@...afoo.de,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH] iio: magnetometer: si7210: fix magnetic field
 measurement scale

On Tue, 4 Feb 2025 19:24:54 +0000
Jonathan Cameron <jic23@...nel.org> wrote:

> On Mon, 3 Feb 2025 20:39:20 +0100
> Antoni Pokusinski <apokusinski01@...il.com> wrote:
> 
> > On Mon, Feb 03, 2025 at 11:26:27AM +0200, Andy Shevchenko wrote:  
> > > On Sun, Feb 02, 2025 at 11:07:10AM +0100, Antoni Pokusinski wrote:    
> > > > Applying the current scale value to the raw magnetic field measurements
> > > > gives the result in mT.
> > > > 
> > > > Fix the scale by increasing it 10 times, so that the final result after
> > > > applying the scale is in Gauss.    
> > > 
> > > No objections against this change, just wondering since these are
> > > the ABI changes (correct?) how should we really handle them in case
> > > some of the user space stuff already relies on 'bad' values?
> > > 
> > > -- 
> > > With Best Regards,
> > > Andy Shevchenko
> > > 
> > >     
> > 
> > Just to clarify: yes, this patch makes the output values compliant to
> > ABI (Documentation/ABI/testing/sysfs-bus-iio). According to the ABI, the
> > output values for the magnetic field should be in Gauss, but during
> > the driver development I missed the fact that I return values in mT
> > instead... (1 Gauss = 0.1mT)
> > 
> > BTW I see that the patch cb29542a178f ("iio: magnetometer: si7210: add
> > driver for Si7210") is still on the "testing" branch only, so perhaps
> > it's still not too late to apply the fix?
> >   
> Ah. I'd not registered that.  Definitely makes life easier.
> This will just get queued up behind it and land upstream at the same
> time.
> 
> Jonathan
Applied.
> 
> > Kind regards,
> > Antoni
> > 
> >   
> 
>