linux-kernel - Re: [PATCH] iio: imu: bmi270: Match ACPI ID found on newer GPD firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250208133058.3e5cb597@jic23-huawei>
Date: Sat, 8 Feb 2025 13:30:58 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Cryolitia PukNgae via B4 Relay <devnull+Cryolitia.gmail.com@...nel.org>
Cc: Cryolitia@...il.com, Alex Lanzano <lanzano.alex@...il.com>, Lars-Peter
 Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, Yao Zi <ziyao@...root.org>
Subject: Re: [PATCH] iio: imu: bmi270: Match ACPI ID found on newer GPD
 firmware

On Thu, 06 Feb 2025 15:09:42 +0800
Cryolitia PukNgae via B4 Relay <devnull+Cryolitia.gmail.com@...nel.org> wrote:

> From: Cryolitia PukNgae <Cryolitia@...il.com>
> 
> Some GPD devices ship a buggy firmware that describes on-device BMI260 with ACPI ID "BMI0160". Since this is fixed in BIOS update v0.40[1], let's match the correct ID to detect the device. The buggy ID "BMI0160" is kept as well to maintain compatibility with older firmwares.
> 
> ---

This --- will break git picking up this patch as the
sign off etc will be misgin.

> Some GPD devices ship a buggy firmware that describes on-device BMI260 with ACPI ID "BMI0160". Since this is fixed in BIOS update v0.40[1], let's match the correct ID to detect the device. The buggy ID "BMI0160" is kept as well to maintain compatibility with older firmwares.
Please wrap commit message at 75 chars
> 
> Link: http://download.softwincn.com/WIN%20Max%202024/Max2-7840-BIOS-V0.41.zip
Link is an official tag so move down to the line above (no blank line) the
Sign off and if you want to refer to it use
Link: http://download.softwincn.com/WIN%20Max%202024/Max2-7840-BIOS-V0.41.zip # [1]
or similar (so a comment after the tag).


If you have any means to tell the manufacturer that this is not a complaint ID
please do. They need to allocate them from their own ID space. 
They are unlikely to be the Benson Medical Instruments company.
https://uefi.org/PNP_ID_List?pnp_search=BMI

So either GPD need to get their on PNP ID  (or ACPI ID) or they need
to ask Bosch (BSG) to issue an ID for this sensor.

It would really help if Windows stopped accepting drivers that made up these
IDs, but I guess that ship long sailed.

Jonathan

> 
> [1]. See the update nodes in the archive file above
> 
> Signed-off-by: Cryolitia PukNgae <Cryolitia@...il.com>
> ---
>  drivers/iio/imu/bmi270/bmi270_i2c.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c
> index 44699ab589097eaa0eec5f2172245496ed031185..f66ae01e301df24f1e563e059da8cc531fc173eb 100644
> --- a/drivers/iio/imu/bmi270/bmi270_i2c.c
> +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c
> @@ -40,6 +40,8 @@ static const struct i2c_device_id bmi270_i2c_id[] = {
>  static const struct acpi_device_id bmi270_acpi_match[] = {
>  	/* GPD Win Mini, Aya Neo AIR Pro, OXP Mini Pro, etc. */
>  	{ "BMI0160",  (kernel_ulong_t)&bmi260_chip_info },
> +	/* GPD Win Max 2 2023(sincice BIOS v0.40), etc. */

since

> +	{ "BMI0260",  (kernel_ulong_t)&bmi260_chip_info },
>  	{ }
>  };
>  
> 
> ---
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> change-id: 20250206-bmi270-gpd-acpi-de4d12bce567
> 
> Best regards,