linux-kernel - Re: [PATCH net-next v3 2/2] net: phy: dp83tg720: Add randomized polling intervals for unstable link detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250207163421.0a1122ec@kernel.org>
Date: Fri, 7 Feb 2025 16:34:21 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, kernel@...gutronix.de, linux-kernel@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 2/2] net: phy: dp83tg720: Add randomized
 polling intervals for unstable link detection

On Thu,  6 Feb 2025 10:39:02 +0100 Oleksij Rempel wrote:
> +static unsigned int dp83tg720_phy_get_next_update_time(struct phy_device *phydev)

over 80 chars, why did you decide to put the word "phy" into this
function name

> +		/* When the link is up, use a fixed 1000ms interval (in jiffies) */

comment over 80 chars