linux-kernel - Re: [PATCH v7 2/3] firmware: add Exynos ACPM protocol driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502082233.qjIDyD3Z-lkp@intel.com>
Date: Sat, 8 Feb 2025 23:00:57 +0800
From: kernel test robot <lkp@...el.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Jassi Brar <jassisinghbrar@...il.com>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, andre.draszik@...aro.org,
	kernel-team@...roid.com, willmcvicker@...gle.com,
	peter.griffin@...aro.org, daniel.lezcano@...aro.org,
	vincent.guittot@...aro.org, ulf.hansson@...aro.org, arnd@...db.de,
	Tudor Ambarus <tudor.ambarus@...aro.org>
Subject: Re: [PATCH v7 2/3] firmware: add Exynos ACPM protocol driver

Hi Tudor,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 2014c95afecee3e76ca4a56956a936e23283f05b]

url:    https://github.com/intel-lab-lkp/linux/commits/Tudor-Ambarus/dt-bindings-firmware-add-google-gs101-acpm-ipc/20250207-233333
base:   2014c95afecee3e76ca4a56956a936e23283f05b
patch link:    https://lore.kernel.org/r/20250207-gs101-acpm-v7-2-ffd7b2fb15ae%40linaro.org
patch subject: [PATCH v7 2/3] firmware: add Exynos ACPM protocol driver
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20250208/202502082233.qjIDyD3Z-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250208/202502082233.qjIDyD3Z-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502082233.qjIDyD3Z-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/firmware/samsung/exynos-acpm.c:646: warning: expecting prototype for acpm_put_handle(). Prototype was for acpm_handle_put() instead


vim +646 drivers/firmware/samsung/exynos-acpm.c

   640	
   641	/**
   642	 * acpm_put_handle() - release the handle acquired by acpm_get_by_phandle.
   643	 * @handle:	Handle acquired by acpm_get_by_phandle.
   644	 */
   645	static void acpm_handle_put(const struct acpm_handle *handle)
 > 646	{
   647		struct acpm_info *acpm = handle_to_acpm_info(handle);
   648		struct device *dev = acpm->dev;
   649	
   650		module_put(dev->driver->owner);
   651		/* Drop reference taken with of_find_device_by_node(). */
   652		put_device(dev);
   653	}
   654	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki